1557954 - Perma broken webconsole and browser console when Gecko 69 merges to Beta on 2019-07-01

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Narcis Beleuzu [:NarcisB]]

[Tracking Requested - why for this release]:

Central as beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=435a7f210b6579776c29830a8f3bb30053d7a44b&searchStr=test-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-8%2Cm%28bc8%29

Log link:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250774005&repo=try&lineNumber=4080

Comment 1

[Cosmin Sabou [:CosminS]]

Looks to have started from: https://hg.mozilla.org/mozilla-central/rev/5ad0d430d2c
Some other log links:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250776492&repo=try&lineNumber=3465
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250773918&repo=try&lineNumber=7808
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250778705&repo=try&lineNumber=1519
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250779401&repo=try&lineNumber=1437
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250779645&repo=try&lineNumber=720

13:54:55 INFO - TEST-START | devtools/client/debugger/test/mochitest/browser_dbg-breaking-from-console.js
13:54:55 INFO - GECKO(5932) | console.error: (new ReferenceError("ResizeObserver is not defined", "resource://devtools/client/webconsole/components/FilterBar.js", 60))
13:54:55 INFO - GECKO(5932) | WebConsolePanel open failed. undefined: ResizeObserver is not defined
13:54:55 INFO - GECKO(5932) | console.error: "WebConsolePanel open failed. undefined: ResizeObserver is not defined" (new ReferenceError("ResizeObserver is not defined", "resource://devtools/client/webconsole/components/FilterBar.js", 60))
13:54:55 INFO - TEST-INFO | started process screenshot
13:54:55 INFO - TEST-INFO | screenshot: exit 0
13:54:55 INFO - Buffered messages logged at 13:54:55
13:54:55 INFO - Entering test bound
13:54:55 INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/debugger/test/mochitest/examples/doc-script-switching.html
13:54:55 INFO - Tab added and finished loading
13:54:55 INFO - Opening the toolbox
13:54:55 INFO - Toolbox opened and focused
13:54:55 INFO - Buffered messages finished
13:54:55 INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-breaking-from-console.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-breaking-from-console.js:17 - TypeError: toolbox.getPanel(...).hud is null
13:54:55 INFO - Stack trace:
13:54:55 INFO - @chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-breaking-from-console.js:17:24
13:54:55 INFO - Leaving test bound
13:54:55 INFO - GECKO(5932) | console.error: "Panel webconsole:" (new TypeError("this.hud is null", "resource://devtools/client/webconsole/panel.js", 93))
13:54:55 INFO - GECKO(5932) | console.warn: "Error while detaching the thread front: 'detach' request packet to 'server1.conn4.child1/context18' can't be sent as the connection is closed."
13:54:55 INFO - Removing tab.
13:54:55 INFO - Waiting for event: 'TabClose' on [object XULElement].
13:54:55 INFO - Got event: 'TabClose' on [object XULElement].
13:54:55 INFO - Tab removed and finished closing
13:54:55 INFO - GECKO(5932) | MEMORY STAT | vsize 2104263MB | vsizeMaxContiguous 65161466MB | residentFast 341MB | heapAllocated 131MB
13:54:55 INFO - TEST-OK | devtools/client/debugger/test/mochitest/browser_dbg-breaking-from-console.js | took 757ms

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bisection reveals it's a regression from bug 1523864.

Comment 6

[Cosmin Sabou [:CosminS]]

Sebastian, could these failures also be related to this bug? https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=435a7f210b6579776c29830a8f3bb30053d7a44b&searchStr=mochitest-e10s&selectedJob=250776838
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250776838&repo=try&lineNumber=4087

13:24:25 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_background_page.html | monitorConsole | messages left expected at least 2 got 3
13:24:25 INFO - Buffered messages finished
13:24:25 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_background_page.html | Test timed out.
13:24:25 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
13:24:25 INFO - reportError@SimpleTest/TestRunner.js:121:22
13:24:25 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
13:24:26 INFO - Not taking screenshot here: see the one that was previously logged
13:24:26 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_background_page.html | Extension left running at test shutdown
13:24:26 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
13:24:26 INFO - ExtensionTestUtils.loadExtension/<@SimpleTest/ExtensionTestUtils.js:109:18
13:24:26 INFO - executeCleanupFunction@SimpleTest/SimpleTest.js:1236:19
13:24:26 INFO - SimpleTest.finish@SimpleTest/SimpleTest.js:1249:5
13:24:26 INFO - killTest@SimpleTest/TestRunner.js:130:22
13:24:26 INFO - delayedKillTest@SimpleTest/TestRunner.js:157:47
13:24:26 INFO - GECKO(2389) | MEMORY STAT | vsize 5082MB | residentFast 109MB | heapAllocated 14MB
13:24:26 INFO - TEST-OK | toolkit/components/extensions/test/mochitest/test_ext_background_page.html | took 328373ms
13:24:29 INFO - Error: Unable to restore focus, expect failures and timeouts.
13:24:29 ERROR - /tests/toolkit/components/extensions/test/mochitest/test_ext_background_page.html logged result after SimpleTest.finish(): Extension left running at test shutdown

Or could it be from Bug 1505909? https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=d08ae3b73857fa05a83bcd320022481cf6684018
Please let us know if we need a new bug for the above kind of failures. This is the m-c pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=debc7af30b7e0ee50653706c19a10511ceefff83&tochange=b5355bd2162ba5740469820ee518649e7fc0b953. Thank you.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

That test mentions "monitor" and "console". As the console is broken, this is supposed to be the same issue like this bug.

Comment 8

[Intermittent Failures Robot]

47 failures in 250 pushes (0.188 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 47

Platform breakdown:

• windows7-32-shippable: 5
• linux64-shippable: 5
• linux64: 10
• macosx1010-64: 1
• macosx1010-64-devedition: 2
• macosx1010-64-shippable: 1
• windows10-64-qr: 2
• windows10-64: 4
• windows7-32: 3
• linux64-devedition: 3
• windows7-32-devedition: 4
• windows10-64-devedition: 2
• windows10-64-shippable-qr: 3
• windows10-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557954&startday=2019-06-08&endday=2019-06-08&tree=all

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

This is because the console now use the ResizeObserver, which is still Nightly only (See Bug 1543839).
There's a patch on that bug to enable it everywhere. Do you want me to still workaround that while waiting for the patch to land ?

Comment 10

[Intermittent Failures Robot]

47 failures in 5197 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

This is the #44 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• try: 47

Platform breakdown:

• linux64: 10
• macosx1010-64: 1
• macosx1010-64-devedition: 2
• macosx1010-64-shippable: 1
• windows10-64-qr: 2
• windows10-64: 4
• windows7-32: 3
• windows7-32-shippable: 5
• linux64-shippable: 5
• linux64-devedition: 3
• windows7-32-devedition: 4
• windows10-64-devedition: 2
• windows10-64-shippable-qr: 3
• windows10-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557954&startday=2019-06-03&endday=2019-06-09&tree=all

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thanks. Let's go with importing the patch from bug 1543839 into the beta simulations.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

It's not 100% clear to me if we're going to ship ResizeObserver on 69, fwiw.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #12)

It's not 100% clear to me if we're going to ship ResizeObserver on 69, fwiw.

Looks like the patch is close to landing. Otherwise I think we should find another solution here if it can't land this week still since we're down to just over 2 weeks left this cycle before soft freeze.

Comment 14

[Nicolas Chevobbe [:nchevobbe]]

Since Bug 1543839, we should be good right?

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Fixed in latest beta sim (by bug 1543839): https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=0041316d1b27102c11af7558f5aa230605ac767e