1544516 - Add ability to specify intent when launching android app

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Robert Wood [:rwood]]

Currently Raptor launches the android app using the default intent of 'android.intent.action.Main' (mozdevice ADBDevice) [0].

For Fenix we need to use the intent 'android.intent.action.VIEW' instead. Add support to Raptor for an 'intent' command line argument. If that argument is not provided default to 'android.intent.action.Main'. Pass in the intent when launching the app at [1].

[0] https://searchfox.org/mozilla-central/rev/1b2636e8517aa48422ed516affe4d28cb7fa220a/testing/mozbase/mozdevice/mozdevice/adb.py#3095

[1] https://searchfox.org/mozilla-central/rev/1b2636e8517aa48422ed516affe4d28cb7fa220a/testing/raptor/raptor/raptor.py#615

Comment 1

[Nick Alexander :nalexander [he/him]]

Yeah, this totally makes sense. After Bug 1533385, I want us to steer toward launching without a specific Activity:

am start -W -a android.intent.action.VIEW -d URL $PACKAGE

should work and simplify everybody's lives (if I'm reading the am start documentation correctly).

Comment 2

[Robert Wood [:rwood]]

Attachment: Bug 1544516 - Add ability to specify intent when launching android app; r?davehunt

Comment 3

[Robert Wood [:rwood]]

(In reply to Robert Wood [:rwood] from comment #2)

Adds support for '--intent' command line arg. To test locally install the latest raptor-release fenix app, and add this section to raptor/raptor/tests/raptor-tp6m-1.ini:

[raptor-tp6m-google-fenix]
apps = fenix
test_url = https://www.google.com
playback_pageset_manifest = mitmproxy-recordings-raptor-tp6m-google.manifest
playback_recordings = android-google.mp
measure = fnbpaint, fcp, dcf, loadtime

Since activity and intent defaults are provided in raptor/cmdline.py, you can just run:

./mach raptor-test --test raptor-tp6m-google-fenix --app fenix --binary org.mozilla.fenix

Or specify everything:

./mach raptor-test --test raptor-tp6m-google-fenix --app fenix --binary org.mozilla.fenix --activity browser.BrowserPerformanceTestActivity --intent android.intent.action.VIEW

Comment 4

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44d95a527eae13c7f016879f0c7bff687c0a7f6d

(sanity check Raptor on other platforms, not Fenix)

Comment 5

[Robert Wood [:rwood]]

Quick try run after post-review update:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=815d7ebc1faf63be909bc5359a9ea8e40aec7541

Comment 6

[Robert Wood [:rwood]]

Patch failed to autoland, merge conflicts. Rebased, updated phab, pushed to try for quick sanity check:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3780493c245c55b461cee131199730a2348b75b6

Comment 7

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=92eecf09a0af035e6f449e9205d5d8b5a9897c16

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56716e17c88d
Add ability to specify intent when launching android app; r=davehunt

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/56716e17c88d