1544590 - Dynamic changes to 'counter-set' doesn't trigger reflow properly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Mats Palmgren (inactive)]

Attachment: 'counter-set' testcase

STR

1. load the attached testcase in Nightly

ACTUAL RESULT
"3."

EXPECTED RESULT
"1."

ADDITIONAL INFO
Just opening devtools (F12) makes the testcase render correctly.

Comment 1

[Mats Palmgren (inactive)]

Attachment: 'counter-increment' testcase

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 9058438 [details]
'counter-increment' testcase

The same test using 'counter-increment' instead works correctly though...

Comment 3

[Mats Palmgren (inactive)]

Oops, I forgot to add it here somehow:
https://searchfox.org/mozilla-central/source/layout/style/nsStyleStruct.cpp#3654

Comment 4

[Mats Palmgren (inactive)]

Hmm, I did have that originally actually:
https://bugzilla.mozilla.org/attachment.cgi?id=9034771&action=diff#a/layout/style/nsStyleStruct.cpp_sec2
However, the patch that landed is missing the changes to nsStyleStruct.cpp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/467284f16c74
Weird... I wonder if I was bitten by the clang-format extension bug there?

Comment 5

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b82db63d0ddaeb211d2c10679194724f91a9e686

Comment 6

[Mats Palmgren (inactive)]

Attachment: Bug 1544590 - Add the missing change hint for 'counter-set'. r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30ab155d08d2
Add the missing change hint for 'counter-set'.  r=emilio

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/30ab155d08d2

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16500 for changes under testing/web-platform/tests