Closed Bug 1544590 Opened 2 years ago Closed 2 years ago

Dynamic changes to 'counter-set' doesn't trigger reflow properly

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox-esr60 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

(Keywords: regression, testcase)

Attachments

(3 files)

Attached file 'counter-set' testcase

STR

  1. load the attached testcase in Nightly

ACTUAL RESULT
"3."

EXPECTED RESULT
"1."

ADDITIONAL INFO
Just opening devtools (F12) makes the testcase render correctly.

Comment on attachment 9058438 [details]
'counter-increment' testcase

The same test using 'counter-increment' instead works correctly though...
Attachment #9058438 - Attachment description: 'counter-increment → 'counter-increment' testcase
Assignee: nobody → mats

Hmm, I did have that originally actually:
https://bugzilla.mozilla.org/attachment.cgi?id=9034771&action=diff#a/layout/style/nsStyleStruct.cpp_sec2
However, the patch that landed is missing the changes to nsStyleStruct.cpp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/467284f16c74
Weird... I wonder if I was bitten by the clang-format extension bug there?

Blocks: 478135
Blocks: 1542871
Keywords: regression
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30ab155d08d2
Add the missing change hint for 'counter-set'.  r=emilio
Flags: in-testsuite+
OS: Linux → All
Hardware: x86_64 → All
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16500 for changes under testing/web-platform/tests
You need to log in before you can comment on or make changes to this bug.