Move the bottom border from #navigator-toolbox::after to #navigator-toolbox

RESOLVED FIXED in Firefox 68

Status

()

task
P2
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks 1 bug)

Trunk
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 months ago
No description provided.
Assignee

Updated

2 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Assignee

Updated

2 months ago
No longer depends on: 1544012
See Also: → 1544012

Comment 2

2 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3dc461058c5
Move the bottom border from #navigator-toolbox::after to #navigator-toolbox. r=ntim

Comment 3

2 months ago

Backed out for perma failures on browser_ext_themes_separators.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&selectedJob=241257153&searchStr=bc5%2Cwindows&revision=a3dc461058c55ccfb3865ccb26c256ff7edb4896

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241257153&repo=autoland&lineNumber=27167

21:21:18 INFO - TEST-START | toolkit/components/extensions/test/browser/browser_ext_themes_separators.js
21:21:19 INFO - TEST-INFO | started process screenshot
21:21:19 INFO - TEST-INFO | screenshot: exit 0
21:21:19 INFO - Buffered messages logged at 21:21:18
21:21:19 INFO - Entering test bound test_support_separator_properties
21:21:19 INFO - Extension loaded
21:21:19 INFO - Console message: Warning: attempting to write 4839 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
21:21:19 INFO - Buffered messages logged at 21:21:19
21:21:19 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_separators.js | Top separator color properly set - true == true -
21:21:19 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_separators.js | Toolbar field separator color properly set - "rgb(148, 0, 255)" == "rgb(148, 0, 255)" -
21:21:19 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_separators.js | Vertical separator color properly set - true == true -
21:21:19 INFO - Buffered messages finished
21:21:19 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_separators.js | Bottom separator color properly set - "rgb(250, 201, 110)" == "rgb(51, 102, 204)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_separators.js :: test_support_separator_properties :: line 66
21:21:19 INFO - Stack trace:
21:21:19 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_separators.js:test_support_separator_properties:66
21:21:19 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
21:21:19 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
21:21:19 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
21:21:19 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
21:21:19 INFO - Leaving test bound test_support_separator_properties
21:21:19 INFO - GECKO(3492) | MEMORY STAT | vsize 863MB | vsizeMaxContiguous 336MB | residentFast 356MB | heapAllocated 158MB

backout: https://hg.mozilla.org/integration/autoland/rev/47f2ce075ee679590b11f34efbfc6152e418d35e

Flags: needinfo?(dao+bmo)
Assignee

Updated

2 months ago
Flags: needinfo?(dao+bmo)

Comment 4

2 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e76e4330c6d
Move the bottom border from #navigator-toolbox::after to #navigator-toolbox. r=ntim
Assignee

Updated

2 months ago
Blocks: 1543152

Comment 5

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Updated

2 months ago
Regressions: 1547473
You need to log in before you can comment on or make changes to this bug.