1544694 - Convert SourceClient to a Protocol.js front

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Yulia Startsev [:yulia]]

Part of migrating the ThreadClient to a front is simplifying its API. The sourceClient is a dependancy of the threadclient and migrating it to a front before migrating threadclient would make that work easier. We already have the spec file https://searchfox.org/mozilla-central/source/devtools/shared/specs/source.js

File to be converted: https://searchfox.org/mozilla-central/source/devtools/shared/client/source-client.js

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1544694 - remove unused method 'getExecutableLines' from sourceClient; r=ochameau

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1544694 - remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1544694 - Convert Source Client to a Front; r=ochameau

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1544694 - move and rename SourceClient to SourceFront; r=ochameau

Comment 5

[Yulia Startsev [:yulia]]

Attachment: Bug 1544694 -fix RetVal types for sourceFront; r=ochameau

We had an alias for the blackbox method in the old client, to name it blackBox. this is
a pretty minimal change but the discrepency is confusing. I switched everything to be blackbox as
it is consistent with the server.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc739beb6782
remove unused method 'getExecutableLines' from sourceClient; r=ochameau,jdescottes,loganfsmyth
https://hg.mozilla.org/integration/autoland/rev/63d133aae187
remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes

Comment 7

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1544694) for XPCshell failures in devtools/server/tests/unit/test_blackboxing-01.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241986546&repo=autoland&lineNumber=2030

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=241972235&revision=63d133aae187fde835f9f9a0b9f83bdbada8dcd8

Backout:
https://hg.mozilla.org/integration/autoland/rev/d6cdc1f35851af085218a5306a171599c92885fb

Comment 8

[Yulia Startsev [:yulia]]

Thanks, looks like the second patch needs to be part of the change to front.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66fe93fc552c
remove unused method 'getExecutableLines' from sourceClient; r=ochameau,jdescottes,loganfsmyth

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/66fe93fc552c

Comment 11

[Yulia Startsev [:yulia]]

final test run: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=242826037&revision=915ea4d5da5d79cfa623b48f479fee5cadd17d91

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c36551d262a
remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes
https://hg.mozilla.org/integration/autoland/rev/27e6d1a417e2
Convert Source Client to a Front; r=ochameau,jdescottes
https://hg.mozilla.org/integration/autoland/rev/96682cfce65c
move and rename SourceClient to SourceFront; r=ochameau,jdescottes

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9c36551d262a
https://hg.mozilla.org/mozilla-central/rev/27e6d1a417e2
https://hg.mozilla.org/mozilla-central/rev/96682cfce65c