Closed Bug 1544694 Opened 9 months ago Closed 9 months ago

Convert SourceClient to a Protocol.js front

Categories

(DevTools :: Framework, task, P3)

task

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: yulia, Assigned: yulia)

References

Details

(Whiteboard: dt-fission)

Attachments

(5 files)

Part of migrating the ThreadClient to a front is simplifying its API. The sourceClient is a dependancy of the threadclient and migrating it to a front before migrating threadclient would make that work easier. We already have the spec file https://searchfox.org/mozilla-central/source/devtools/shared/specs/source.js

File to be converted: https://searchfox.org/mozilla-central/source/devtools/shared/client/source-client.js

Type: defect → task
Depends on: 1545021

We had an alias for the blackbox method in the old client, to name it blackBox. this is
a pretty minimal change but the discrepency is confusing. I switched everything to be blackbox as
it is consistent with the server.

Attachment #9058936 - Attachment description: Bug 1544694 - fix blackboxing tests due to name change; r=ochameau → Bug 1544694 -fix RetVal types for front; r=ochameau
Attachment #9058936 - Attachment description: Bug 1544694 -fix RetVal types for front; r=ochameau → Bug 1544694 -fix RetVal types for sourceFront; r=ochameau
Depends on: 1544697
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc739beb6782
remove unused method 'getExecutableLines' from sourceClient; r=ochameau,jdescottes,loganfsmyth
https://hg.mozilla.org/integration/autoland/rev/63d133aae187
remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes

Thanks, looks like the second patch needs to be part of the change to front.

Flags: needinfo?(ystartsev)
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66fe93fc552c
remove unused method 'getExecutableLines' from sourceClient; r=ochameau,jdescottes,loganfsmyth
Keywords: leave-open
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c36551d262a
remove unused client getters 'request' and '_transport' from sourceClient; r=ochameau,jdescottes
https://hg.mozilla.org/integration/autoland/rev/27e6d1a417e2
Convert Source Client to a Front; r=ochameau,jdescottes
https://hg.mozilla.org/integration/autoland/rev/96682cfce65c
move and rename SourceClient to SourceFront; r=ochameau,jdescottes
Keywords: leave-open
Assignee: nobody → ystartsev
You need to log in before you can comment on or make changes to this bug.