Investigate Using LongStringFront instead of LongStringClient

RESOLVED FIXED in Firefox 68

Status

task
P3
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: yulia, Assigned: yulia)

Tracking

unspecified
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: dt-fission)

Attachments

(1 attachment, 1 obsolete attachment)

In the ThreadClient, We are currently using the LongStringClient: https://searchfox.org/mozilla-central/source/devtools/shared/client/thread-client.js#376

It is also used in the webconsole, and some tests: https://searchfox.org/mozilla-central/search?q=longstringclient&path=

LongStringClient has already been converted to a front:
Client code - https://searchfox.org/mozilla-central/source/devtools/shared/client/long-string-client.js

Front: https://searchfox.org/mozilla-central/source/devtools/shared/fronts/string.js
Spec: https://searchfox.org/mozilla-central/source/devtools/shared/specs/string.js

however the front is not used anywhere: https://searchfox.org/mozilla-central/search?q=longstringfront&path=

It looks like this was a partially completed refactor but I cannot find the original bug. This should be completed.

Type: defect → task
Priority: -- → P3

we have two longstring actors in the codebase. This switches the source actor from using
devtools/server/actors/object/long-string.js to using devtools/server/actors/string.js. The two are
almost equivalent, but it looks like we should migrate all usages to string.js

Blocks: 1544694

I am not sure this is necessary, but this memoizes the response from onSource in a simpler
way. What happened before, is we would memoize the response on the pool object, and make it a weak
reference. However this reference is linked to the source object. We don't have multiple source
texts for a single source. It also appears that we cache the source on the client side.

Attachment #9060104 - Attachment is obsolete: true
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/542c3b51efa1
use LongStringFront in SourceFront; r=ochameau,jdescottes
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Assignee: nobody → ystartsev
You need to log in before you can comment on or make changes to this bug.