1545052 - "The address isn't valid" page displayed if we open Privacy menu from about:telemetry

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect, P1)

Description

[Sorina Florean [:sflorean]]

Attachment: Screenshot_2019-04-17-12-12-54.png

Environment:
Device:

• Nokia 6 (Android 7.1.1);
• Nexus 9(Android 7.1.1);
• Samsung Galaxy Note 8 (Android 9);
• Xiaomi Mi4i (Android 5.0.2);

Build: Nightly 68.0a1 (2019-04-16);

Steps to reproduce:

1. Go to about:telemetry;
2. Tap "Enabled" hyperlink.

Expected result:
The Privacy menu is displayed.

Actual result:
"The address isn't valid" page is displayed.

Performed a regression window and from pushlog this issue is regressed by bug 1523741.

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=eb89a2f2c59cd45726b4590af38227d65c23b68e&tochange=61f5baa6ed8cdced571731b346e2f44f52508be5

Comment 1

[Sorina Florean [:sflorean]]

Avery Berninger, can you take a look, please?

Comment 2

[:Gijs (he/him)]

From the diff:

+++ b/toolkit/content/aboutTelemetry.js

...

   /**
    * Updates the button & text at the top of the page to reflect Telemetry state.
    */
   render() {
     let settingsExplanation = document.getElementById("settings-explanation");
-    let uploadEnabled = this.getStatusString(TelemetrySend.sendingEnabled());
     let extendedEnabled = Services.telemetry.canRecordExtended;
-    let collectedData = bundle.GetStringFromName(extendedEnabled ? "prereleaseData" : "releaseData");
-    let explanation = bundle.GetStringFromName("settingsExplanation");
 
-    let fragment = BrowserUtils.getLocalizedFragment(document, explanation, collectedData, this.convertStringToLink(uploadEnabled));
-    settingsExplanation.appendChild(fragment);
+    let datacase = extendedEnabled ? "prerelease" : "release";
+    let uploadcase = TelemetrySend.sendingEnabled() ? "enabled" : "disabled";
+
+    document.l10n.setAttributes(settingsExplanation, "about-telemetry-settings-explanation", {datacase, uploadcase});

We shouldn't hardcode about:preferences#privacy, and instead ensure this code:

https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/toolkit/content/aboutTelemetry.js#178-193

continues to run for clicks on this link. We can probably just get away with removing the href from the markup and adding the class attribute on which that code relies, though it'll need testing. We should also remove https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/toolkit/content/aboutTelemetry.js#217-223 which is now unused, as far as I can tell.

Comment 3

[Avery Berninger]

Absolutely, I will take a look today.

Comment 4

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

This is a regression in Fennec 68 from Fluent L10n bug 1523741.

Comment 5

[Avery Berninger]

Attachment: Bug 1545052 - Fix broken about:preferences link (Android), r?Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d6de1b4d5f9
Fix broken about:preferences link (Android), r=Gijs

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7d6de1b4d5f9

Comment 8

[:Gijs (he/him)]

Can you verify this has been fixed once this hits android nightlies? Thanks.

Comment 9

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly build (68.0a1 - 04/23).
Devices:

• Xiaomi Mi4i (Android 5.0.2);
• Nexus 6P (Android 8.1.0);
• Sony Xperia Z5 Premium (Android 7.1.1);