1545129 - Conditional Breakpoints - pressing enter in the panel adds a new line

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Jason Laster [:jlast]]

STR:

1. right click on a line
2. select add a conditional breakpoint
3. type in the panel
4. move the cursor somewhere in the middle of the text
5. press enter

ER: saves the condition
AR: saves the condition w/ a new line where the cursor was

Comment 1

[David Walsh :davidwalsh]

I believe this was introduced with the change to allow the new line for logpoints.

Comment 2

[Chujun Lu]

I came up with a different approach to tackle the issue I showed to David in Tuesday's meeting. I'm comparing two implementations. Will send a patch when I'm ready. :)

Comment 3

[David Walsh :davidwalsh]

Thank you Chujun!

Comment 4

[Chujun Lu]

Attachment: Bug 1545129 Prevent "Enter" event from adding a new line in CodeMirror r=davidwalsh

The conditional breakpoint panel is wrapped in CodeMirror (starting from https://github.com/firefox-devtools/debugger/commit/6b0b968515ee0511899f80feb95a25d1f855073d). When hitting Enter, debugger/node_modules/codemirror/lib/codemirror.js will run line 7153 onKeyDown(), in which a new line is added. Then ConditionalPanel.js onKey() runs.

Solution: Ask CodeMirror not to add a new line when hit Enter.

Question:
I added two test cases to Mochitest. If I put a debugger; statement in the test file, ran ./mach mochitest --jsdebugger file/path, keepstep over, all tests pass. But when I ran./mach mochitest same/file/path`, terminal stopped at "waiting for state change" then gave an error "Failed to retrieve MOZ_UPLOAD_DIR env var."

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/178ad5eddb72
Prevent "Enter" event from adding a new line in CodeMirror r=davidwalsh

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/178ad5eddb72