1545255 - referrer not sent when loading - loadUri(String uri, String referrer, int flags)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[colormatch]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

load a geckoview session with:

geckoSession.loadUri("https://www.whatsmyreferer.com/","www.SomeRef.com",0);

or

geckoSession.loadUri("https://www.whatsmyreferer.com/",Uri.encode("www.SomeRef.com"),0);

Actual results:

Page loads without sent referrer header.

Expected results:

referrer header should have been sent when loading via:

void loadUri(String uri, String referrer, int flags)
Load the given URI with the specified referrer and load type.

void loadUri(Uri uri, Uri referrer, int flags)
Load the given URI with the specified referrer and load type.

Comment 1

[Eugen Sawin [:esawin]]

That's a regression from bug 1517703, we need to pass a ReferrerInfo.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Ugh. Clearly we need a test for this too.

Comment 3

[Chris Peterson [:cpeterson]]

Custom tabs will need the referrer, too.

Comment 4

[Eugen Sawin [:esawin]]

Attachment: Bug 1545255 - [1.0] Use ReferrerInfo when loading URIs in GeckoView.

Comment 5

[Eugen Sawin [:esawin]]

Attachment: Bug 1545255 - [2.0] Add GeckoSession.loadUri() referrer test.

Depends on D29683

Comment 6

[Chris Peterson [:cpeterson]]

Eugen, does Fennec have this same bug?

Comment 7

[Eugen Sawin [:esawin]]

Yes, Fennec has been regressed, too. I think Emily is working on that.

Comment 8

[Eugen Sawin [:esawin]]

Gijs, you've done the original review for the ReferrerInfo usage conversion, can you redirect your review to someone suitable in the respect?

Comment 9

[:Gijs (he/him)]

(In reply to Eugen Sawin [:esawin] from comment #8)

Gijs, you've done the original review for the ReferrerInfo usage conversion, can you redirect your review to someone suitable in the respect?

snorp was already listed as a reviewer, that seemed OK to me?

Comment 10

[Eugen Sawin [:esawin]]

(In reply to :Gijs (he/him) from comment #9)

(In reply to Eugen Sawin [:esawin] from comment #8)

Gijs, you've done the original review for the ReferrerInfo usage conversion, can you redirect your review to someone suitable in the respect?

snorp was already listed as a reviewer, that seemed OK to me?

It's probably OK, but I wanted to make sure that I'm using the new loadUri API correctly, snorp was tagged for the "is this correct for GV" part.

Comment 11

[:Gijs (he/him)]

(In reply to Eugen Sawin [:esawin] from comment #10)

It's probably OK, but I wanted to make sure that I'm using the new loadUri API correctly

Assuming browser is an instance of the CE in browser-custom-element.js, yes.

In fact, how does that call work today? :-\

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7323ab06d60
[1.0] Use ReferrerInfo when loading URIs in GeckoView. r=snorp
https://hg.mozilla.org/integration/autoland/rev/c8216edb37a9
[2.0] Add GeckoSession.loadUri() referrer test. r=snorp

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f7323ab06d60
https://hg.mozilla.org/mozilla-central/rev/c8216edb37a9