1545726 - Implement DOM.getBoxModel

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

https://chromedevtools.github.io/devtools-protocol/tot/DOM#method-getBoxModel
DOM.getBoxModel
Returns boxes for the given node.

This is being used from Wordpress test suite over here:
https://github.com/WordPress/gutenberg/blob/master/packages/e2e-tests/specs/links.test.js#L469

const settings = await page.$( '.block-editor-url-popover__settings' );
const bounds = await settings.boundingBox();

https://github.com/GoogleChrome/puppeteer/blob/5ee21d97e796263857b9f3fbeaf63366179d346f/lib/JSHandle.js#L309-L310
https://github.com/GoogleChrome/puppeteer/blob/5ee21d97e796263857b9f3fbeaf63366179d346f/lib/JSHandle.js#L222-L223

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1545726 - Implement DOM.getBoxModel.

Comment 2

[Alexandre Poirot [:ochameau]]

Unfortunately, I'm not able to fix the tests on all platforms because of results being differents between high-dpi versus normal dpi.
On top of that with high-dpi, I get decimals and I'm not sure chromium exposes decimal pixels.

So. I'll try to proceed with the code while keeping the tests for followups.
This apply to this bug as well as bug 1549063.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d375a95f85e
Implement DOM.getBoxModel. r=remote-protocol-reviewers,ato

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8d375a95f85e