1543098 - Emit Runtime.executionContextCreated and executionContextDestroyed events

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

https://chromedevtools.github.io/devtools-protocol/tot/Runtime#event-executionContextCreated
Runtime.executionContextCreated:
Issued when new execution context is created.

This is a preliminary work in supporting JS evaluation via puppeteer's Page.evaluate.
This depends on bug 1543095 as on te puppeteer's side, we have to receive the Page.frameNavigated event first before this Runtime.executionContextCreated event.

Runtime.executionContextCreated is fired every time there is a new JS context into which we can execute code. Here we are going to only target tab documents, but later this can expose workers, addons,...

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1543098 - Implement Runtime.executionContextCreated.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1543098 - Implement Runtime.executionContextDestroyed.

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=025bb1fe6f8d63b93071daaa6f1bf57a741f6497

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1543098 - Emit executionContextCreated for existing context when calling Runtime.enable.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1543098 - Emit executionContextDestroyed and executionContextCreated when the page goes into/out of the BF Cache.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a13ac4fa9d7
Implement Runtime.executionContextCreated. r=ato
https://hg.mozilla.org/integration/autoland/rev/142fc2db9173
Emit executionContextCreated for existing context when calling Runtime.enable. r=ato
https://hg.mozilla.org/integration/autoland/rev/f5645934c8ec
Implement Runtime.executionContextDestroyed. r=ato
https://hg.mozilla.org/integration/autoland/rev/a414e99fbbc8
Emit executionContextDestroyed and executionContextCreated when the page goes into/out of the BF Cache. r=ato

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0a13ac4fa9d7
https://hg.mozilla.org/mozilla-central/rev/142fc2db9173
https://hg.mozilla.org/mozilla-central/rev/f5645934c8ec
https://hg.mozilla.org/mozilla-central/rev/a414e99fbbc8

Comment 8

[Andrei Ciure[:aciure]]

Backed out 4 changesets (bug 1543098) for high frequency browser_runtime_executionContext.js failures

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a414e99fbbc856d82d5cf2561e2df3dd9638b6f2&selectedJob=243601513

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.10%2Cshippable%2Copt%2Cmochitests%2Ctest-macosx64-shippable%2Fopt-mochitest-browser-chrome-e10s-4%2Cm%28bc4%29&fromchange=cbdf3fdfcbac59d4ccac118d2e6a96ac360a94a5&selectedJob=243900433

backout: https://hg.mozilla.org/integration/autoland/rev/6843d141c496ade289d5d162532d9fc6d479e78c

Comment 9

[Alexandre Poirot [:ochameau]]

Note for the sheriffs:

I relanded this patch queue with the intermittent test disable on mac and windows+verify.
If there is other configurations where this test appears to be intermittent I would prefer disabling the patch rather than backing out the changes.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bee2c531149
Implement Runtime.executionContextCreated. r=ato
https://hg.mozilla.org/integration/autoland/rev/d2402ee68ab2
Emit executionContextCreated for existing context when calling Runtime.enable. r=ato
https://hg.mozilla.org/integration/autoland/rev/3673c2b20d7f
Implement Runtime.executionContextDestroyed. r=ato
https://hg.mozilla.org/integration/autoland/rev/e104355e0f27
Emit executionContextDestroyed and executionContextCreated when the page goes into/out of the BF Cache. r=ato

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7bee2c531149
https://hg.mozilla.org/mozilla-central/rev/d2402ee68ab2
https://hg.mozilla.org/mozilla-central/rev/3673c2b20d7f
https://hg.mozilla.org/mozilla-central/rev/e104355e0f27