Closed Bug 1543098 Opened 8 months ago Closed 7 months ago

Emit Runtime.executionContextCreated and executionContextDestroyed events

Categories

(Remote Protocol :: Runtime, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 68

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 4 open bugs)

Details

Attachments

(4 files)

https://chromedevtools.github.io/devtools-protocol/tot/Runtime#event-executionContextCreated
Runtime.executionContextCreated:
Issued when new execution context is created.

This is a preliminary work in supporting JS evaluation via puppeteer's Page.evaluate.
This depends on bug 1543095 as on te puppeteer's side, we have to receive the Page.frameNavigated event first before this Runtime.executionContextCreated event.

Runtime.executionContextCreated is fired every time there is a new JS context into which we can execute code. Here we are going to only target tab documents, but later this can expose workers, addons,...

Blocks: 1543099
Status: NEW → ASSIGNED
Priority: -- → P1
Blocks: 1543151
Blocks: 1545726
Attachment #9058290 - Attachment description: Bug 1543098 - Implement Runtime.executionContextCreated → Bug 1543098 - Implement Runtime.executionContextCreated.
Attachment #9058291 - Attachment description: Bug 1543098 - Implement Runtime.executionContextDestroyed → Bug 1543098 - Implement Runtime.executionContextDestroyed.
Summary: Emit Runtime.executionContextCreated event → Emit Runtime.executionContextCreated and executionContextDestroyed events
Blocks: 1547198
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a13ac4fa9d7
Implement Runtime.executionContextCreated. r=ato
https://hg.mozilla.org/integration/autoland/rev/142fc2db9173
Emit executionContextCreated for existing context when calling Runtime.enable. r=ato
https://hg.mozilla.org/integration/autoland/rev/f5645934c8ec
Implement Runtime.executionContextDestroyed. r=ato
https://hg.mozilla.org/integration/autoland/rev/a414e99fbbc8
Emit executionContextDestroyed and executionContextCreated when the page goes into/out of the BF Cache. r=ato
Blocks: 1548102
Regressions: 1547961

Note for the sheriffs:

I relanded this patch queue with the intermittent test disable on mac and windows+verify.
If there is other configurations where this test appears to be intermittent I would prefer disabling the patch rather than backing out the changes.

Flags: needinfo?(poirot.alex)
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7bee2c531149
Implement Runtime.executionContextCreated. r=ato
https://hg.mozilla.org/integration/autoland/rev/d2402ee68ab2
Emit executionContextCreated for existing context when calling Runtime.enable. r=ato
https://hg.mozilla.org/integration/autoland/rev/3673c2b20d7f
Implement Runtime.executionContextDestroyed. r=ato
https://hg.mozilla.org/integration/autoland/rev/e104355e0f27
Emit executionContextDestroyed and executionContextCreated when the page goes into/out of the BF Cache. r=ato
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.