1545932 - Opening a browserAction button should return focus to the previous location when closed

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P3)

Description

[Philipp Kewisch [:Fallen][📱📆]]

STR:

• Create a WX add-on with a browser action and a keyboard shortcut for it
• Navigate to message pane
• Press keyboard shortcut (clicking also works), do things in the browser action that will finally close the popup window

Expected:

• The focus returns to the message pane tree, arrow keys will allow moving to the next message

Actual:

• The focus goes to the window object, not the tree it was previously at

This is essential for add-ons that aim to improve keyboard navigation and make actions for selected items, such as my quickmove extension. Here is a wx version of the add-on you can use for testing: https://github.com/kewisch/quickmove-extension/tree/webextension

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

I'm thinking about where to best implement this. My initial thought was saving document.activeElement when the popup is opened, and then returning to that when closed. Any thoughts darktrojan?

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9094863 [details] [diff] [review]
Fix - v1

Seems reasonable.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0f867b01c12b
Return focus to previous element when closing browser action. r=darktrojan

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 9094863 [details] [diff] [review]
Fix - v1

I'd like to see this in release if possible, it will help me get rid of hacks for an add-on I'm working on.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9094863 [details] [diff] [review]
Fix - v1

Too bad we didn't include it in TB 70 beta 3 which shipped two days ago. I guess there's no harm done sticking it into the next available ESR release or would you like some beta exposure first. Seems like a small low-risk patch.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

To me this seems low risk and I don't think it needs a beta cycle, I trust your judgement though.

Comment 8

[Jorg K (CEST = GMT+2)]

TB 70 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/0e203dc1c0338a650d2fe3b2aed097cfadfdf7f7

We decided to do beta 4, so in it went. Will go into 68.2 after that.

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68.2.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/e08dd8151b3281553f308d1558af21e5c8ff53e4