1546147 - ghost text box appears in One-Click Search Engines list of about:preferences

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Alice0775 White]

Attachment: image.png

Steps to Reproduce:

1. about:preferences
2. Search
3. Double click to edit keyword
4. General
   --- Browser console shows the following error
5. Search and scroll to One-Click Search Engines
   --- ghost text box appears
6. Click a search engine
   --- ghost text box is still there

Actual Results:
Browser console shows the following error

TypeError: aEvent is undefined search.js:282:18
onInputBlur chrome://browser/content/preferences/in-content/search.js:282
handleEvent chrome://browser/content/preferences/in-content/search.js:241
TypeError: this.view is null tree.js:1152:9
stopEditing chrome://global/content/elements/tree.js:1152
setupEventListeners chrome://global/content/elements/tree.js:693

And ghost text box appears

Expected Results:
No error, no ghost text box

Comment 1

[:Gijs (out for now; he/him)]

Thanks for providing all the relevant info (esp. error messages) in comment #0, looks like fixing this is pretty trivial.

Comment 2

[:Gijs (out for now; he/him)]

Attachment: Bug 1546147 - fix broken search keyword textbox when switching categories, r?vporof

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7ee53a44d58
fix broken search keyword textbox when switching categories, r=vporof

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d7ee53a44d58

Comment 6

[Maria Berlinger [:mberlinger], Services QA]

I have managed to reproduce this issue on an affected Firefox 67.0b12 build using Windows 10 x64 by following the STR from comment 0.

This issue is verified fixed using Firefox 68.0b7 on the following OSes: Windows 10 x64, Ubuntu 18.04 x64, Windows 7 x64, macOS 10.13.6.