1601240 - One-Click search keyword reset if changing preference pane / category

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Cristian Fogel [:cfogel]]

Attachment: oneOFkeyowrd.gif

Affected versions

• 73.0a1 (2019-12-03), 71.0b12, 72.0b2, 68.3esr

Affected platforms

• Windows 10;

Steps to reproduce

1. Launch Firefox and access about:preferences#search
2. Scroll down to One-Click Search Engines;
3. Double click to display keyword input field in the Search engine list view (e.g. Double click "Bing" row).
4. Type keyword and do not press the ENTER key (e.g. "b" not include quotation);
5. Click on the "General" pane;
6. Click "Search" pane;
7. Click anywhere on the word typed at Step 3 and start typing again.

Expected result

• user can edit the keyword

Actual result

• the selection being reset & field not editable anymore

Regression range

• First bad: 2019-04-24
• Last good: : 2019-04-23
• Pushlog: URL
• Potential regressor: 1546147, 1518551 look like canditates for it;

Additional notes

• attached recording with the issue;

Comment 1

[:Gijs (out for now; he/him)]

(In reply to Cristian Fogel, QA [:cfogel] from comment #0)

Regression range

• First bad: 2019-04-24
• Last good: : 2019-04-23
• Pushlog: URL
• Potential regressor: 1546147, 1518551 look like canditates for it;

This URL too looks wrong, it's several days bigger than the first bad / last good dates.

Comment 2

[:Gijs (out for now; he/him)]

(In reply to Cristian Fogel, QA [:cfogel] from comment #0)

Steps to reproduce

1. Launch Firefox and access about:preferences#search
2. Scroll down to One-Click Search Engines;
3. Double click to display keyword input field in the Search engine list view (e.g. Double click "Bing" row).
4. Type keyword and do not press the ENTER key (e.g. "b" not include quotation);
5. Click on the "General" pane;
6. Click "Search" pane;
7. Click anywhere on the word typed at Step 3 and start typing again.

Expected result

• user can edit the keyword

Actual result

• the selection being reset & field not editable anymore

I don't really understand these steps. What I see is that the keyword is not saved, but doubleclicking the row again works and I can edit a keyword then. Is that not what you're seeing?

Comment 3

[Cristian Fogel [:cfogel]]

Based on the discussion on Slack, closing this issue as well as invalid.
The fix from the previous patches, was in fact the expected behavior:

• text box being usable after swapping the category;
• text box being reset after changing and not saving the input(making this issue invalid).