1546385 - remote/test/browser/browser_target.js | Found a tab after previous test timed out: about:blank

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P1)

Description

[Andreas Tolfsen ❲:ato❳]

See full context in https://bugzilla.mozilla.org/show_bug.cgi?id=1533831#c13.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1546385: remote: listen for target to connect sooner;

TabManager.addTab(), and consequently gBrowser.addTab(), causes
tabs to open before Target#createTarget() gets time to install an
listener for a new target.

Since targets are created on the TabOpen event, we must install the
listener before we open the tab. This has the consequence that we
cannot reliably tell where the first target that connects comes from.
For this reason, this makes a functional change to return an error
if such an eventuality should arise.

This patch fixes the failing remote/test/browser/browser_target.js
browser-chrome test.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1546385: remote: listen for target to connect sooner;

TabManager.addTab(), and consequently gBrowser.addTab(), causes
tabs to open before Target#createTarget() gets time to install an
listener for a new target.

Since targets are created on the TabOpen event, we must install the
listener before we open the tab. This has the consequence that we
cannot reliably tell where the first target that connects comes from.
For this reason, this makes a functional change to return an error
if such an eventuality should arise.

This patch fixes the failing remote/test/browser/browser_target.js
browser-chrome test.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea2444833ad7
remote: listen for target to connect sooner; r=ochameau

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ea2444833ad7