Hardcoded layout results in only one new tab page rendered with discovery stream content

VERIFIED FIXED in Firefox 68

Status

()

defect
P1
normal
VERIFIED FIXED
3 months ago
25 days ago

People

(Reporter: Mardak, Assigned: thecount)

Tracking

(Regression, {github-merged})

unspecified
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 verified)

Details

Attachments

(3 attachments)

https://github.com/mozilla/activity-stream/pull/4904/files#r277979670

The expiration logic doesn't handle hardcoded layout correctly resulting in layout being refreshed and subsequently spocs endpoint which makes it look like spocs are not loaded preventing the rendering of content.

The code in bug 1543800 introduced the regression while bug 1545122 flipped the pref to turn it on.

Regressed by: 1545122

Leaving open to temporarily disable hardcoded layout

Keywords: leave-open
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7be98a7e5fc4
Disable hardcoded layout to avoid expiration issues r=andreio

Maybe I was too proactive in reverting the pref. This problem seems to only happen for new profiles where the cache has no existing layout entry. So existing people on nightly have a cached layout and will see the hardcoded layout somewhat correctly.. maybe (?)

Blocks: 1546808
Keywords: leave-open
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4f22be5eb41
Reenable hardcoded layout with expiration fixed r=andreio
Status: NEW → RESOLVED
Closed: 3 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190429215338) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the articles are correctly loaded on each "New Tab" page.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.