1546590 - Hardcoded layout results in only one new tab page rendered with discovery stream content

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ed Lee :Mardak]

https://github.com/mozilla/activity-stream/pull/4904/files#r277979670

The expiration logic doesn't handle hardcoded layout correctly resulting in layout being refreshed and subsequently spocs endpoint which makes it look like spocs are not loaded preventing the rendering of content.

Comment 1

[Ed Lee :Mardak]

The code in bug 1543800 introduced the regression while bug 1545122 flipped the pref to turn it on.

Comment 2

[Ed Lee :Mardak]

Leaving open to temporarily disable hardcoded layout

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1546590 - Disable hardcoded layout to avoid expiration issues

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7be98a7e5fc4
Disable hardcoded layout to avoid expiration issues r=andreio

Comment 5

[Ed Lee :Mardak]

Maybe I was too proactive in reverting the pref. This problem seems to only happen for new profiles where the cache has no existing layout entry. So existing people on nightly have a cached layout and will see the hardcoded layout somewhat correctly.. maybe (?)

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4930

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7be98a7e5fc4

Comment 8

[Ed Lee :Mardak]

Attachment: Bug 1546590 - Reenable hardcoded layout with expiration fixed

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4f22be5eb41
Reenable hardcoded layout with expiration fixed r=andreio

Comment 10

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/45c374ffa2a1

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d4f22be5eb41

Comment 12

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190429215338) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the articles are correctly loaded on each "New Tab" page.