1546732 - windows/aarch64 - enable jittest

Status: RESOLVED FIXED

(Testing :: General, task)

Description

[Edwin Takahashi (:egao | infrequent contributor)]

Enable jittest for windows10-aarch64 on try and mozilla-central.

Disable any tests that fail as part of this work.

Try server should continue to require the --full command line argument in order to schedule tasks.

Comment 1

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1546732 - enable jittest for windows10-aarch64

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc42ae4e7a3a
enable jittest for windows10-aarch64 r=gbrown

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dc42ae4e7a3a

Comment 4

[Geoff Brown [:gbrown]]

This did not start running jittest on central. I think that's because of:

https://searchfox.org/mozilla-central/rev/d143f8ce30d1bcfee7a1227c27bf876a85f8cede/taskcluster/ci/test/compiled.yml#95

...which makes me wonder, should we run SM instead?

Comment 5

[Edwin Takahashi (:egao | infrequent contributor)]

(In reply to Geoff Brown [:gbrown] (pto April 26-29) from comment #4)

This did not start running jittest on central. I think that's because of:

https://searchfox.org/mozilla-central/rev/d143f8ce30d1bcfee7a1227c27bf876a85f8cede/taskcluster/ci/test/compiled.yml#95

...which makes me wonder, should we run SM instead?

Checked the base regex (?=windows).*(?!-ccov) with regex tester, and it does catch this example string windows10-aarch64. What if I make the regex more specific? That may be not worth the amount of hours spent on it.

Are Jit and SpiderMonkey the same thing?

Comment 6

[Geoff Brown [:gbrown]]

I know very little about the SpiderMonkey tests.

:jmaher, :cpeterson -- windows/aarch64 jittest is ready for mozilla-central, but we have noticed that jittest is not normally run on Windows -- a comment says it is redundant with SpiderMonkey. Can you shed light on that? Ultimately we want to know: Do we want to run windows/aarch64 jittest, and do we want to run windows/aarch64 SM?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

running jittest on win/aarch64 allows us to gain arm64 coverage. The plan is:
win/aarch64:

• jittest
• jsreftest

android/arm7:

• jittest
• jsreftest

the goal here is to have good coverage for arm7 and arm64.

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Geoff Brown [:gbrown] (pto April 26-29) from comment #6)

:jmaher, :cpeterson -- windows/aarch64 jittest is ready for mozilla-central, but we have noticed that jittest is not normally run on Windows -- a comment says it is redundant with SpiderMonkey. Can you shed light on that? Ultimately we want to know: Do we want to run windows/aarch64 jittest, and do we want to run windows/aarch64 SM?

Sean, why are the jittests "redundant with SM(p)" [1] on Windows? Is this true for windows/aarch64?

https://searchfox.org/mozilla-central/rev/d143f8ce30d1bcfee7a1227c27bf876a85f8cede/taskcluster/ci/test/compiled.yml#95

Comment 9

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1546732 - enable jittest on try, mozilla-central for windows10-aarch64 r=gbrown

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/500cdbe0977e
enable jittest on try, mozilla-central for windows10-aarch64 r=gbrown

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/500cdbe0977e

Comment 12

[Sean Stangl [:sstangl]]

Sean, why are the jittests "redundant with SM(p)" [1] on Windows? Is this true for windows/aarch64?

If I'm reading js/src/devtools/automation/autospider.py correctly, the default options of SM(p) run all of "jstests", "jittest", "jsapitests", and "checks".

Based on that, I think it would be true for windows/aarch64 also, if we turn on SM(p).