1547050 - builtin search extensions are not loaded in safe mode

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Alice0775 White]

Reproducible: always

Steps To Reproduce:

1. Start Nightly68.0a1 with safe mode

2. Type text in address bar or Search bar
   --- observe One-off search button icon

3. Open about:preferences#search
   --- observe One-off search button icon

Actual Results:
No icon

Expected Results:
Icon hould be shown

Comment 1

[Mark Banner (:standard8)]

Also affects the address bar. I strongly suspect this is due to the built-in Search WebExtensions being partially(?) disabled in safe mode.

Comment 2

[Mike de Boer [:mikedeboer]]

(In reply to Mark Banner (:standard8) from comment #1)

Also affects the address bar. I strongly suspect this is due to the built-in Search WebExtensions being partially(?) disabled in safe mode.

Not sure whether this would be a release blocker, but it's a regression nonetheless. Shane, what are your thoughts here? Is this something we'd like to change AddonManager behavior for?

Comment 3

[Shane Caraveo (:mixedpuppy)]

ISTM that searchservice should just detect safe mode on startup, and rely only on its cache in that case. Presumably firefox wouldn't be starting a new profile in safe mode. Otherwise, we probably have to make some exception for built-in extension. I'd like input from aswan on that.

Comment 4

[Andrew Swan [:aswan]]

Simple is probably to add the builtin location to
https://searchfox.org/mozilla-central/rev/444ee13e14fe30451651c0f62b3979c76766ada4/toolkit/mozapps/extensions/internal/XPIProvider.jsm#284

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1547050 support builtin extensions in safemode

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca33e95075c3
support builtin extensions in safemode r=aswan

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ca33e95075c3