1547054 - Thunderbird - Remove unnecessary type attributes (i.e. [type="application/javascript"])

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1546501 +++

Remove unnecessary type=application/javascript, per bug 1546501, which has a script which needs some adjustment: https://bugzilla.mozilla.org/attachment.cgi?id=9060222

Comment 1

[Magnus Melin [:mkmelin]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4747f09f6892cfc8987dd9898e75b08868eaab36

Comment 2

[Magnus Melin [:mkmelin]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e4db91a1edd9d28f61c92cbb46033a94fe35faf0 - looks ok.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: find-replace-script-type-non-test.sh (c-c adapted)

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1547054_type_app_js_removal.patch

[no manual corrections needed from what the script produced]

This bitrots almost instantly.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9061180 [details] [diff] [review]
bug1547054_type_app_js_removal.patch

Thanks.

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Magnus Melin [:mkmelin] from comment #4)

This bitrots almost instantly.

Then you should land it with PLR or wait until M-C remove the ability to have the attribute and then land it as bustage-fix ;-)

Comment 7

[Magnus Melin [:mkmelin]]

If there's much bitrot I'll just rerun the script and check there wasn't any odd additional changes.

Comment 8

[Jorg K (CEST = GMT+2)]

Up to you. Or you could split the patch in half. As I said, it may become a bustage-fix necessity, but I don't know when M-C will make it necessary.

Comment 9

[Magnus Melin [:mkmelin]]

The background is that XUL documents (like always was the case for HTML) now no longer require setting a type on scripts, so it's just removing unnecessary defaults. Specifying a type will still work forever I assume.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/340b555c26cf
Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags. r=Paenglab,philipp DONTBUILD

Comment 11

[Jorg K (CEST = GMT+2)]

Fixed one rot manually.