Closed Bug 1547054 Opened 2 years ago Closed 2 years ago

Thunderbird - Remove unnecessary type attributes (i.e. [type="application/javascript"])

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1546501 +++

Remove unnecessary type=application/javascript, per bug 1546501, which has a script which needs some adjustment: https://bugzilla.mozilla.org/attachment.cgi?id=9060222

Type: defect → task

[no manual corrections needed from what the script produced]

This bitrots almost instantly.

Attachment #9061180 - Flags: review?(richard.marti)
Attachment #9061180 - Flags: review?(philipp)
Status: NEW → ASSIGNED
Summary: Thunderbird - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags → Thunderbird - Remove unnecessary type attributes (i.e. [type="application/javascript"])
Comment on attachment 9061180 [details] [diff] [review]
bug1547054_type_app_js_removal.patch

Thanks.
Attachment #9061180 - Flags: review?(richard.marti) → review+

(In reply to Magnus Melin [:mkmelin] from comment #4)

This bitrots almost instantly.

Then you should land it with PLR or wait until M-C remove the ability to have the attribute and then land it as bustage-fix ;-)

If there's much bitrot I'll just rerun the script and check there wasn't any odd additional changes.

Up to you. Or you could split the patch in half. As I said, it may become a bustage-fix necessity, but I don't know when M-C will make it necessary.

The background is that XUL documents (like always was the case for HTML) now no longer require setting a type on scripts, so it's just removing unnecessary defaults. Specifying a type will still work forever I assume.

Attachment #9061180 - Flags: review?(philipp) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/340b555c26cf
Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags. r=Paenglab,philipp DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Fixed one rot manually.

Target Milestone: --- → Thunderbird 68.0
You need to log in before you can comment on or make changes to this bug.