Give IntrinsicSize a constructor that initializes both members as nscoord values
Categories
(Core :: Layout, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
It's reasonably common for us to have to construct or return a temporary IntrinsicSize object with nscoord-flavored values in each dimension.
Let's just create a convenience constructor for this purpose.
|
||
Comment 1•5 years ago
|
||
FWIW, unrelated, but IntrinsicSize should probably not use nsStyleCoord, and just use Maybe<nscoord>. But I'm happy to do that as a followup to this bug or what not.
|
Assignee | |
Comment 2•5 years ago
|
||
This patch shouldn't affect behavior; it's just simplifying exisitng code with
a new convenience constructor.
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
FWIW, unrelated, but IntrinsicSize should probably not use nsStyleCoord, and just use
Maybe<nscoord>. But I'm happy to do that as a followup to this bug or what not.
That sounds like a good idea - thanks for suggesting/filing that.
This bug here is just a convenience bug in response to a review comment on bug 1544121, to make its patch a bit more minimal, so I'm happy to keep it small in scope. :)
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a704e5e6a3c Give nsIFrame::IntrinsicSize a convenience constructor that takes nscoord-valued width and height. r=TYLin
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•