IntrinsicSize shouldn't use nsStyleCoord.

RESOLVED FIXED in Firefox 68

Status

()

task
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

I think this is a nice follow-up to bug 1547126.

No longer blocks: 1547126
Depends on: 1547126

We have a better type to represent "a coord or nothing", and that's Maybe.

This code is shorter, and I think reads generally better / is less easy to
misuse.

I wrote this on top of bug 1547126 so there shouldn't be conflicts.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41ee8dc862a9
IntrinsicSize shouldn't use nsStyleCoord. r=dholbert
Type: defect → task
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/ee95a11e12ed
followup: Let the compiler generate more IntrinsicSize functions as suggested by TYLin.
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1547261
Depends on: 1547513
You need to log in before you can comment on or make changes to this bug.