Closed
Bug 1547138
Opened 6 years ago
Closed 6 years ago
IntrinsicSize shouldn't use nsStyleCoord.
Categories
(Core :: Layout, task, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
I think this is a nice follow-up to bug 1547126.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
We have a better type to represent "a coord or nothing", and that's Maybe.
This code is shorter, and I think reads generally better / is less easy to
misuse.
I wrote this on top of bug 1547126 so there shouldn't be conflicts.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41ee8dc862a9
IntrinsicSize shouldn't use nsStyleCoord. r=dholbert
|
||
Updated•6 years ago
|
Type: defect → task
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/ee95a11e12ed
followup: Let the compiler generate more IntrinsicSize functions as suggested by TYLin.
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/41ee8dc862a9
https://hg.mozilla.org/mozilla-central/rev/ee95a11e12ed
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1547261
You need to log in
before you can comment on or make changes to this bug.
Description
•