1547269 - Don't put LLVM in $PATH since we now prefer .mozbuild

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

We added detection of system-installed LLVM for windows in bug 1238251; since we now use .mozbuild and pull clang from there for windows (or want to), if this adds LLVM from the system (Program Files (x86)) it breaks builds and uses the wrong LLVM/clang.

Comment 1

[(Away)]

Bug 1238251 was OK in its time, when anything related to LLVM on Windows was a personal customization that you had to set up explicitly. Presumably at that point you were aware of what did and didn't work, etc.

But nowadays, with so many build pieces defaulting to LLVM, we should really prefer .mozbuild because it often contains compiler patches that our tree requires. People who aren't tinkering with compilers shouldn't have to think about whether their system LLVM is appropriate or not; things should Just Work by default.

Comment 2

[Mike Hommey [:glandium]]

Bug 1519954 prioritized .mozbuild over $PATH, so, practically speaking, this is fixed.

Comment 3

[(Away)]

This was fixed in bug 1253212.