1547285 - Add the registerProvider function API

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Mike de Boer [:mikedeboer]]

For more info, see the design doc over at https://docs.google.com/document/d/11c-OTsscmArnqL02Kq1TUPKtkHl4avmC3pDdSJDC6JI/edit

Lots of internals to touch and define interaction among providers. A few unknowns, how the API functions, not determined yet.

Comment 1

[Marco Bonardo [:mak]]

First steps here would be to add an API to the ProvidersManager to register these "dynamic" providers, and make it manage the filter and restrict functions for them:

• if something restricts, we drop any other provider from a search.
• if something provides a filter, we can use it instead or in addition to sources (may we completely replace sources with filter also for built-in providers, simplifying the whole thing?)
  This should also somehow manage the case of a provider that asks to restrict, but wants to be filtered out for that case, then we should ignore the restrict flag.

As for other WebExt cases, we'll make so that in case of conflict (2 providers willing to restrict) the newest registered one wins. Ideally it would be the most recently installed add-on. We should check if WebExt are started up in install date order or not.

Comment 2

[Marco Bonardo [:mak]]

merging back the dependency, in the end it's simpler to do everything here.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1547285 - Add the registerProvider function API. r=adw,mixedpuppy

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0efaeeb61292
Add the registerProvider function API. r=adw,mixedpuppy

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0efaeeb61292