154741 - Multiple line text isn't displayed if it's in an inline element with an floating image

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Koike Kazuhiko]

if there are an floating image and multiple line text in an inline element,
and the height of the image is smaller than that of the text,
the text in the second line and after isn't displayed.

<span>
<img>Line1<br>Line2
</span>

Comment 1

[Koike Kazuhiko]

Testcase:
http://bugzilla.mozilla.gr.jp/showattachment.cgi?attach_id=912

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: simplified testcase

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Dump Frames is showing that the text frame for the second line has an empty
string inside it.  It doesn't seem like something of this type would be messed
up during frame construction, particularly since it depends on the size of the
float, so it seems like the problem has something to do with the code that's
breaking lines during reflow.

Comment 4

[kinmoz]

The br and "Line 2" frames never get reflowed.

While reflowing the "Line 1" text frame, nsTextFrame::Reflow() sets the
NS_FRAME_TRUNCATED bit in the passed in aStatus, which triggers the following
code in nsInlineFrame::ReflowFrames() which bails without reflowing any frames
after the "Line 1" text frame:


528 karnaze  3.179 if (NS_FRAME_COMPLETE != aStatus) {
529 kipp     3.121   if (!reflowingFirstLetter || NS_INLINE_IS_BREAK(aStatus)) {
530                    done = PR_TRUE;
531                    break;
532                  }
533                }


I verified that jumping over this code in the debugger allows everything to
reflow and render.

In case anyone is wondering, here are the aReflowState and aMetrics fields that
are causing the NS_FRAME_TRUNCATED bits to be set in nsTextFrame::Reflow():


  aReflowState.mFlags.mIsTopOfPage == PR_FALSE
  aReflowState.availableHeight == 120
  aMetrics.height == 285

If I modify the html file so that it uses a non-floated image, or no image at
all, aReflowState.availableHeight is unconstrained.

Comment 5

[kinmoz]

According to cvs blame the NS_FRAME_SET_TRUNCATION() macro call in
nsTextFrame::Reflow() was added when the fix for floater splitting was checked
in on the TRUNK back in May:

5485 karnaze      1.369 NS_FRAME_SET_TRUNCATION(aStatus, aReflowState, aMetrics);

This bug doesn't exist on the MOZILLA_1_0_BRANCH.

Comment 6

[karnaze (gone)]

taking the bug.

Comment 7

[karnaze (gone)]

Attachment: patch to use reflow status macros rather than NS_FRAME_COMPLETE

The patch uses reflow status macros instead of checking against
NS_FRAME_COMPLETE. The patch in bug 145305 made a feeble attempt at this, since
it added a new bit to check for truncation in the reflow status.

Comment 8

[Alexandru Savulov]

Comment on attachment 90688 [details] [diff] [review]
patch to use reflow status macros rather than NS_FRAME_COMPLETE

r= alexsavulov

Comment 9

[kinmoz]

Comment on attachment 90688 [details] [diff] [review]
patch to use reflow status macros rather than NS_FRAME_COMPLETE

sr=[e-mail]

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 90688 [details] [diff] [review]
patch to use reflow status macros rather than NS_FRAME_COMPLETE

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

Comment 11

[karnaze (gone)]

the patch is in.