145305 - Floaters don't split when printing

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[karnaze (gone)]

The block and inline code does not split floaters. We also have hacks in 
html.css to not honor align=left,right on tables to avoid the data loss from not 
being able to split floaters.

Comment 1

[karnaze (gone)]

Attachment: raptor jpg

Comment 2

[karnaze (gone)]

Attachment: test 1 - float left image, no text on page 2

Comment 3

[karnaze (gone)]

Attachment: test 2 - float right image, no text on page 2

Comment 4

[karnaze (gone)]

Attachment: test 3 - float left table, no text on page 2

Comment 5

[karnaze (gone)]

Attachment: test 4 - float right table, no text on page 2

Comment 6

[karnaze (gone)]

Attachment: test 5 - 2 float left images, no text on page 2

Comment 7

[karnaze (gone)]

Attachment: test 6 - 2 float right images, no text on page 2

Comment 8

[karnaze (gone)]

Attachment: test 7 - 2 float right tables, no text on page 2

Comment 9

[karnaze (gone)]

Attachment: test 8 - float left image, text on page 2

Comment 10

[karnaze (gone)]

Attachment: test 9 - float left table, text on page 2

Comment 11

[karnaze (gone)]

Attachment: test 10 - float right image, text on page 2

Comment 12

[karnaze (gone)]

Attachment: test 11 - float right table, text on page 2

Comment 13

[karnaze (gone)]

Attachment: test 12 - float left image, float right image, text on page 2

Comment 14

[karnaze (gone)]

Attachment: test 13 - float left table, float right table, text on page 2

Comment 15

[karnaze (gone)]

Attachment: test 14 - float right button, float right image, text on page 2

Comment 16

[karnaze (gone)]

Attachment: test 15 - float right button, float right image, float right button, float right image, text on page 2

Comment 17

[karnaze (gone)]

Attachment: test 16 - float right image, float right button, put floaters on next page

Comment 18

[karnaze (gone)]

Attachment: test 17 - float right button, float right table, put floaters on next page

Comment 19

[karnaze (gone)]

Attachment: wip patch that fixes the url and test cases

Comment 20

[karnaze (gone)]

It will be fairly easy to make positioned elements split after landing this 
patch. I'll open another bug for that.

Comment 21

[Håkan Waara]

-  if (nsLayoutAtoms::textFrame == frameType) {
+  if (nsLayoutAtoms::textFrame == frameType.get()) {

There are many changes in your patch like that. I don't think you need the
.get() any longer...

Comment 22

[Chris Petersen]

*** Bug 144300 has been marked as a duplicate of this bug. ***

Comment 23

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 84290 [details] [diff] [review]
wip patch that fixes the url and test cases

>-        if (NS_FAILED(rv)) {
>-          return rv;
>-        }
>+        if (NS_FAILED(rv)) return rv;

Please don't make changes of this form.  They make it
impossible to set breakpoints on the early return.
They also tend to hide the early return, which is bad
both since some error checking is unnecessary or
incorrect (using early returns when the error should
be handled in some way or ignored) and since early
returns should be easily visible since we tend not to
manage things that need to be cleaned up before return
(e.g., freeing objects (except nsCOMPtr usage), reverse
translations, popping state) using destructors (i.e.,
we're nowhere near exception-safe).

Comment 24

[Waldemar Horwat]

Merging keywords and platform from bug 144300.

Comment 25

[Kevin McCluskey (gone)]

nsbeta1-. The fix for this will be too risky to make it on to the branch.

Comment 26

[Marc Attinasi]

Comment on attachment 84290 [details] [diff] [review]
wip patch that fixes the url and test cases

Hey, this looks pretty nice Chris! You have to remove some stuff that is not
suppossed to be in there (bug139524 and the TableColFrame stuff) and also
waterson's changes for TableOuterFrame, as we discussed. Finally, the
SVGOuterSVGFrame change is wrong, the status will be overwritten and SVG frames
won't be able to indicate they are truncated - horrors!

This turned out to be pretty straightforward, sr=attinasi

Comment 27

[Alexandru Savulov]

Comment on attachment 84290 [details] [diff] [review]
wip patch that fixes the url and test cases

r= alexsavulov

great job! way to go dude!:-)

Comment 28

[karnaze (gone)]

Attachment: test 18 - Text, float right image, no text on page 2

Comment 29

[karnaze (gone)]

Attachment: test 19 - text, float right table, text on page 2

Comment 30

[karnaze (gone)]

Attachment: test 20 - Text, float right button, float right image, text on page 2

Comment 31

[karnaze (gone)]

Attachment: test 21 - Text, float right button, float right table, put floaters on next page

Comment 32

[karnaze (gone)]

Attachment: revised patch with reviewers's suggestions and fixing the case of below line floaters.

Comment 33

[Aleksey Nogin]

This check-in have added a warning:

+layout/html/style/src/nsCSSFrameConstructor.cpp:11577
+ `nsresult rv' might be used uninitialized in this function

Comment 34

[karnaze (gone)]

FIXED_ON_TRUNK. I'll fix the warning with my next checkin to 
nsCSSFrameConstructor.cpp.

Comment 35

[Boris 'pi' Piwinger]

Bug 148399, comment 8 suggests, that bug 148399 is caused by this patch here.
Possibly, bug 149364 is the same problem.

I'd higly appreciate if you could look into this issue. TIA

pi

Comment 36

[Boris 'pi' Piwinger]

Bug 148399, comment 8 says, that it is caused by this patch here.
Bug 149364, comment 16 says, that it is caused by this patch here.

So I mark both bugs as being blocked by this here.

pi

Comment 37

[Chris Petersen]

Verified in the Windows ME (2002-08-19-08) and Mac OSX (2002-08-19-05) TRUNK builds.