Closed Bug 1547533 Opened 6 years ago Closed 4 years ago

Intermittent TEST-UNEXPECTED-NOTRUN | /resize-observer/observe.html | guard - expected PASS

Categories

(Core :: Layout, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox70 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: boris)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered])

Attachments

(2 files)

#[markdown(off)]
Filed by: rmaries [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=243136536&repo=mozilla-central

https://queue.taskcluster.net/v1/task/X8yfoYLfQkyoVGp5ZeCAUQ/runs/0/artifacts/public/logs/live_backing.log

[task 2019-04-28T00:31:24.524Z] 00:31:24 INFO - TEST-START | /resize-observer/observe.html
[task 2019-04-28T00:31:24.526Z] 00:31:24 INFO - Closing window 6442450949
[task 2019-04-28T00:31:34.944Z] 00:31:34 INFO -
[task 2019-04-28T00:31:34.945Z] 00:31:34 INFO - TEST-PASS | /resize-observer/observe.html | ResizeObserver implemented
[task 2019-04-28T00:31:34.945Z] 00:31:34 INFO - TEST-UNEXPECTED-NOTRUN | /resize-observer/observe.html | guard - expected PASS
[task 2019-04-28T00:31:34.946Z] 00:31:34 INFO -
[task 2019-04-28T00:31:34.946Z] 00:31:34 INFO - TEST-PASS | /resize-observer/observe.html | test0: simple observation
[task 2019-04-28T00:31:34.946Z] 00:31:34 INFO - TEST-PASS | /resize-observer/observe.html | test1: multiple observation on same element trigger only one
[task 2019-04-28T00:31:34.946Z] 00:31:34 INFO - TEST-PASS | /resize-observer/observe.html | test2: throw exception when observing non-element
[task 2019-04-28T00:31:34.946Z] 00:31:34 INFO - TEST-PASS | /resize-observer/observe.html | test3: disconnect stops all notifications
[task 2019-04-28T00:31:34.946Z] 00:31:34 INFO - TEST-PASS | /resize-observer/observe.html | test4: unobserve target stops notifications, unobserve non-observed does nothing
[task 2019-04-28T00:31:34.947Z] 00:31:34 INFO - TEST-UNEXPECTED-FAIL | /resize-observer/observe.html | test5: observe img - assert_unreached: Timed out waiting for notification. (100ms) Reached unreachable code
[task 2019-04-28T00:31:34.947Z] 00:31:34 INFO - _handleTimeout/<@http://web-platform.test:8000/resize-observer/resources/resizeTestHelper.js:98:9
[task 2019-04-28T00:31:34.947Z] 00:31:34 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1587:25
[task 2019-04-28T00:31:34.947Z] 00:31:34 INFO - _handleTimeout@http://web-platform.test:8000/resize-observer/resources/resizeTestHelper.js:93:23
[task 2019-04-28T00:31:34.948Z] 00:31:34 INFO - Test.prototype.step_timeout/<@http://web-platform.test:8000/resources/testharness.js:1645:22
[task 2019-04-28T00:31:34.948Z] 00:31:34 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1587:25
[task 2019-04-28T00:31:34.948Z] 00:31:34 INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1611:35
[task 2019-04-28T00:31:34.948Z] 00:31:34 INFO - setTimeout handler*Test.prototype.step_timeout@http://web-platform.test:8000/resources/testharness.js:1644:16
[task 2019-04-28T00:31:34.948Z] 00:31:34 INFO - _nextStep@http://web-platform.test:8000/resize-observer/resources/resizeTestHelper.js:65:41
[task 2019-04-28T00:31:34.948Z] 00:31:34 INFO - _handleNotification/<@http://web-platform.test:8000/resize-observer/resources/resizeTestHelper.js:87:14
[task 2019-04-28T00:31:34.949Z] 00:31:34 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1587:25
[task 2019-04-28T00:31:34.949Z] 00:31:34 INFO - _handleNotification@http://web-platform.test:8000/resize-observer/resources/resizeTestHelper.js:82:23
[task 2019-04-28T00:31:34.949Z] 00:31:34 INFO - ResizeObserverCallback*ResizeTestHelper@http://web-platform.test:8000/resize-observer/resources/resizeTestHelper.js:50:22
[task 2019-04-28T00:31:34.949Z] 00:31:34 INFO - test5@http://web-platform.test:8000/resize-observer/observe.html:113:16
[task 2019-04-28T00:31:34.949Z] 00:31:34 INFO - @http://web-platform.test:8000/resize-observer/observe.html:202:24
[task 2019-04-28T00:31:34.949Z] 00:31:34 INFO - promise callback*@http://web-platform.test:8000/resize-observer/observe.html:202:4
[task 2019-04-28T00:31:34.950Z] 00:31:34 INFO - TEST-UNEXPECTED-TIMEOUT | /resize-observer/observe.html | expected OK
[task 2019-04-28T00:31:34.950Z] 00:31:34 INFO - TEST-INFO took 10425ms
[task 2019-04-28T00:31:34.967Z] 00:31:34 INFO - PID 27608 | 1556411494956 Marionette INFO Stopped listening on port 2828
[task 2019-04-28T00:31:35.613Z] 00:31:35 INFO - Browser exited with return code 0
[task 2019-04-28T00:31:35.613Z] 00:31:35 INFO - PROCESS LEAKS None
[task 2019-04-28T00:31:35.614Z] 00:31:35 INFO - Closing logging queue
[task 2019-04-28T00:31:35.614Z] 00:31:35 INFO - queue closed
[task 2019-04-28T00:31:35.635Z] 00:31:35 INFO - Setting up ssl
[task 2019-04-28T00:31:35.663Z] 00:31:35 INFO - certutil |
[task 2019-04-28T00:31:35.691Z] 00:31:35 INFO - certutil |
[task 2019-04-28T00:31:35.711Z] 00:31:35 INFO - certutil |
[task 2019-04-28T00:31:35.711Z] 00:31:35 INFO - Certificate Nickname Trust Attributes
[task 2019-04-28T00:31:35.713Z] 00:31:35 INFO - SSL,S/MIME,JAR/XPI
[task 2019-04-28T00:31:35.713Z] 00:31:35 INFO -
[task 2019-04-28T00:31:35.713Z] 00:31:35 INFO - web-platform-tests CT,,
[task 2019-04-28T00:31:35.713Z] 00:31:35 INFO -
[task 2019-04-28T00:31:35.729Z] 00:31:35 INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmpMB6YvR.mozrunner
[task 2019-04-28T00:31:35.733Z] 00:31:35 INFO - Starting runner
[task 2019-04-28T00:31:36.257Z] 00:31:36 INFO - PID 27910 | 1556411496245 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: mozillaAddons
[task 2019-04-28T00:31:36.258Z] 00:31:36 INFO - PID 27910 | 1556411496246 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: resource://pdf.js/
[task 2019-04-28T00:31:36.259Z] 00:31:36 INFO - PID 27910 | 1556411496246 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: about:reader*
[task 2019-04-28T00:31:42.314Z] 00:31:42 INFO - PID 27910 | 1556411502310 Marionette INFO Listening on port 2828

Flags: needinfo?(boris.chiou)
Regressed by: 1272409

I'd like to add a real image src and wait image.onload event, and then start the test in https://phabricator.services.mozilla.com/D29889. Hope this is helpful.

Flags: needinfo?(boris.chiou)
Summary: Intermittent tier 2 TEST-UNEXPECTED-NOTRUN | /resize-observer/observe.html | guard - expected PASS → Intermittent TEST-UNEXPECTED-NOTRUN | /resize-observer/observe.html | guard - expected PASS

Sounds more likely to be from bug 1543839 and co. Boris any idea?

Flags: needinfo?(emilio) → needinfo?(boris.chiou)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #12)

Sounds more likely to be from bug 1543839 and co. Boris any idea?

I'm trying to reproduce this. However, I think this high occurrence rate (~20%) on beta-sims is not related to bug 1543839 because we always run the wpt with the pref enabled [1], and we don't have any new update in the train (i.e. only enable the pref for normal usage). This log looks like the callback was not called for <img> element [2], and it only happened on web-reneder? if so, the recently change on web-render on image may cause this high occurrence rate. Or maybe it is just a test case issue (e.g. the creation of ResizeObserver is too early because the image is not ready?)

[1] https://searchfox.org/mozilla-beta/rev/dd3976557cf0a37e156f09be4e757af13820b510/testing/web-platform/meta/resize-observer/__dir__.ini#1
[2] https://searchfox.org/mozilla-beta/rev/dd3976557cf0a37e156f09be4e757af13820b510/testing/web-platform/tests/resize-observer/observe.html#133-150

Flags: needinfo?(boris.chiou)

I also see this high occurrence rate in m-c, since June 20, and only happened on linux64 quantum-render.

Based on the suggestion in html spec:
https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode

We decode the image in parallel, and only inserting it into the DOM (and thus
causing it to be painted) once the decoding process is complete.

Because the decode() method attempts to ensure that the decoded image data is
available for at least one frame, it can be combined with the
requestAnimationFrame() API. This means it can be used with coding styles or
frameworks that ensure that all DOM modifications are batched together as
animation frame callbacks.

Hope this could reduce the occurrence rate of this intermittent.

Attachment #9073706 - Attachment description: Bug 1547533 - Update test on <img>. → Bug 1547533 - Update tests on <img>.
Keywords: leave-open

(In reply to Boris Chiou [:boris] from comment #17)

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=22d25fb4aa59a779743d40ccd8bd986b6887e138

Just tried 20 times, and didn't see this failure with this patch. (Those oranges are caused by another intermittent.)

Without this patch, it's easier to reproduce this in m-c, especially on "Linux x64 QuantumRender Shippable opt".

Attachment #9073706 - Attachment description: Bug 1547533 - Update tests on <img>. → Bug 1547533 - Update ResizeObserver tests on <img>.
Pushed by boris.chiou@gmail.com: https://hg.mozilla.org/integration/autoland/rev/28854bf543da Update ResizeObserver tests on <img>. r=dholbert
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17516 for changes under testing/web-platform/tests
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/003d1c976fc6 Update test expectations because of recent failures. r=dholbert

Close this because https://searchfox.org/mozilla-central/source/testing/web-platform/meta/resize-observer/observe.html.ini has mark test5 as intermittent on windows, and the timeout of test5() shouldn't make guard failed now.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → boris.chiou
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: