Closed Bug 1547573 Opened 1 year ago Closed 1 year ago

Built-in themes should appear before user installed themes in Customize mode

Categories

(Firefox :: Toolbars and Customization, defect, P2)

68 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 + fixed

People

(Reporter: ntim, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1540517 +++

Hamburger menu > Customize > Themes initially has three built-in themes and provision for up to six items. Installing more than three additional themes causes the built-in ones to be moved off the bottom of the list, with six themes installed there are no built-in themes in the list at all.

The sorting should be:

themes.sort((a, b) => importantThemes.has(b.id) - importantThemes.has(a.id));

instead of:

themes.sort((a, b) => importantThemes.has(a.id) - importantThemes.has(b.id));

[Tracking Requested - why for this release]:
We tracked bug 1540517 and there's still issues with this bit of the UI.

Hi Gijs, any upates for this one? Will it be fixed for 68?

Flags: needinfo?(gijskruitbosch+bugs)

There's a bunch of brokenness here and I imagine Kris is busy so I'll try and tidy this up for 68.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d87eef05591b
fix sorting in and add test for themes dropdown in customize mode, r=jaws
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.