Built-in themes should appear before user installed themes in Customize mode

RESOLVED FIXED in Firefox 68

Status

()

defect
P2
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: ntim, Assigned: Gijs)

Tracking

(Blocks 1 bug, {regression})

68 Branch
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox66 unaffected, firefox67 unaffected, firefox68+ fixed)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1540517 +++

Hamburger menu > Customize > Themes initially has three built-in themes and provision for up to six items. Installing more than three additional themes causes the built-in ones to be moved off the bottom of the list, with six themes installed there are no built-in themes in the list at all.

The sorting should be:

themes.sort((a, b) => importantThemes.has(b.id) - importantThemes.has(a.id));

instead of:

themes.sort((a, b) => importantThemes.has(a.id) - importantThemes.has(b.id));

[Tracking Requested - why for this release]:
We tracked bug 1540517 and there's still issues with this bit of the UI.

Hi Gijs, any upates for this one? Will it be fixed for 68?

Flags: needinfo?(gijskruitbosch+bugs)

There's a bunch of brokenness here and I imagine Kris is busy so I'll try and tidy this up for 68.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d87eef05591b
fix sorting in and add test for themes dropdown in customize mode, r=jaws
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.