1547573 - Built-in themes should appear before user installed themes in Customize mode

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Tim Nguyen :ntim]

+++ This bug was initially created as a clone of Bug #1540517 +++

Hamburger menu > Customize > Themes initially has three built-in themes and provision for up to six items. Installing more than three additional themes causes the built-in ones to be moved off the bottom of the list, with six themes installed there are no built-in themes in the list at all.

The sorting should be:

themes.sort((a, b) => importantThemes.has(b.id) - importantThemes.has(a.id));

instead of:

themes.sort((a, b) => importantThemes.has(a.id) - importantThemes.has(b.id));

Comment 1

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
We tracked bug 1540517 and there's still issues with this bit of the UI.

Comment 2

[Patricia Lawless]

Hi Gijs, any upates for this one? Will it be fixed for 68?

Comment 3

[:Gijs (he/him)]

There's a bunch of brokenness here and I imagine Kris is busy so I'll try and tidy this up for 68.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1547573 - fix sorting in and add test for themes dropdown in customize mode, r?jaws

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d87eef05591b
fix sorting in and add test for themes dropdown in customize mode, r=jaws

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d87eef05591b