Closed
Bug 154769
Opened 23 years ago
Closed 22 years ago
Mozilla can't animate this broken image
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aha, Assigned: pavlov)
References
()
Details
Attachments
(2 files, 1 obsolete file)
3.10 KB,
patch
|
Biesinger
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
3.03 KB,
patch
|
Details | Diff | Splinter Review |
Mozilla can't animate broken image, but other browsers (MSIE5.0, Opera 6.x,
NN4.79) are able to do it. Mozilla IMHO should also support this sometime in far
future. =)
2002062308/trunk/W2k
Comment 1•23 years ago
|
||
paper, this seems like your thing... ;)
Comment 2•23 years ago
|
||
Confirming under Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1a+)
Gecko/20020619, but why should Mozilla be able to display broken images? If it's
broken, fix it.
Comment 3•23 years ago
|
||
confirming with 1.1beta on win2k.
IE also animates the broken gif (with some corruption on one of the frames).
this could be a wontfix, but that's not my call...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•22 years ago
|
||
*** Bug 195523 has been marked as a duplicate of this bug. ***
Comment 5•22 years ago
|
||
Never saw this bug before until today.. bugmail must have slipped under my
nose. Sorry.
Here's a patch. Upon recieving a Close notification from the stream, this
patch closes off a GIF frame if one is still open, and then it closes off the
GIF if the GIF is still open.
Comment 6•22 years ago
|
||
Another Testcase (from dup'd bug):
http://bugzilla.mozilla.org/attachment.cgi?id=115976&action=view
Updated•22 years ago
|
Attachment #116214 -
Flags: review?(cbiesinger)
Updated•22 years ago
|
Attachment #116214 -
Flags: review?(cbiesinger)
Updated•22 years ago
|
Attachment #116285 -
Flags: review?(cbiesinger)
Comment 8•22 years ago
|
||
Comment on attachment 116285 [details] [diff] [review]
Finish Up Decoding
+ : mImageContainer(nsnull)
+ , mImageFrame(nsnull)
+ , mObserver(nsnull)
No need to explicitly initialize these to nsnull (it's a nsCOMPtr, which are
nsnull by default). Remove this initialization, and r=biesi.
Attachment #116285 -
Flags: review?(cbiesinger) → review+
Updated•22 years ago
|
Attachment #116285 -
Flags: superreview?(tor)
Comment on attachment 116285 [details] [diff] [review]
Finish Up Decoding
Make mGIFOpen a PRPackedBool, do biesi's tidying, and sr=tor.
Attachment #116285 -
Flags: superreview?(tor) → superreview+
Comment 10•22 years ago
|
||
This is the patch I'll check in.
Don't worry about r+/sr+
Comment 11•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•