Closed Bug 1547744 Opened 7 years ago Closed 7 years ago

Wrap Trailhead first run modal in ModalOverlay

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Flags:
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: k88hudson, Assigned: k88hudson)

References

Details

(Keywords: github-merged)

Attachments

(2 files)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4943
52 bytes, text/x-github-pull-request
Details | Review
Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4945
52 bytes, text/x-github-pull-request
Details | Review

Hopefully we can reuse ModalOverlay for this

Assignee: nobody → khudson
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1548388

https://hg.mozilla.org/mozilla-central/rev/34dd0113415f

Iteration: --- → 68.4 - Apr 29 - May 12
status-firefox68: --- → fixed
Keywords: github-merged
Target Milestone: --- → Firefox 68

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190506095034) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the trailhead first run modal is displayed in ModalOverlay.

Status: RESOLVED → VERIFIED
status-firefox68: fixed → verified

Marking verified as per bug 1550098 Comment 13 for bugs that were status-firefox68=verified

status-firefox67: --- → verified
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: