1548000 - Default browser intent chooser options - Just once / Always not shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

To get the framework to present the "Open with" dialog we try to open a http Intent. From there the user can choose Fennec to always open this kind of intents - becoming so the default browser. [1]

This process becomes cumbersome though when the user chooses another application to open only once that http intent.
For the next such try when showing the "Choose with" dialog Android will automatically put at top that application and only it will have the Just once / Always options [2]
So the user can't at this point select another application from the list to Always open such intents.
(He can select another app which on the next "open with" dialog will be the only one having the Just once/Always options)

I think we'll need to hack our way through this to offer a better experience for the user.

[1] https://drive.google.com/file/d/1jJTFJe4mL3LrzyFPS0IJuLmxJjGHGRUI/view
[2] https://drive.google.com/file/d/1d4d-1X0tdj9NVDWnbU7YLdHdiqAwrgaQ/view

Comment 1

[Petru-Mugurel Lingurar [:petru]]

This seems to be the default behavior on Android but we can try to force the Open with dialog to always show the Just once/Always options for all the browsers with this hack - https://stackoverflow.com/a/23374389/4249825

Comment 2

[Chris Peterson [:cpeterson]]

Upgrading this bug from [bcs:p2] to [bcs:p1] because Andreas thinks this bug is an important usability problem. The fix can just ride the trains with Fennec 68. It's too late to uplift fixes to Fennec 67 Beta and this bug probably doesn't warrant a 67.0.x dot release.

Comment 3

[Andreas Bovens [:abovens]]

This bug is important. Is there any way to still get it into 67 beta?

Comment 4

[Andrei Teslovan [:ateslovan]]

I tried the solution Petru suggested (https://stackoverflow.com/a/23374389/4249825) but with no success. It's not working even in the PoC the guy from StackOverflow posted. I investigated a bit more in order to find a possible solution for this but it seems that it's a system behavior and it can't be changed. (https://stackoverflow.com/a/31599147)

Comment 5

[Andreas Bovens [:abovens]]

In that case, we'll have to simplify our implementation.

Going back to my "spec", in https://bugzilla.mozilla.org/show_bug.cgi?id=1544589#c4 , item 4.

This should be simplified to:

"4) Tapping on "Make $Firefox your default browser" should trigger the "Default apps" Android Settings screen, from which a user can pick a default Browser app."

The toast message described in 5) should be shown as well of course — it works when there is a different browser set as default as well as when no browser is set.

Comment 6

[Andrei Teslovan [:ateslovan]]

Attachment: Bug 1548000 - Default browser triggers "Default apps" screen; r?VladBaicu

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Andreas Bovens [:abovens] from comment #3)

This bug is important. Is there any way to still get it into 67 beta?

It's probably too late to uplift fixes to 67 Beta, but we can always ask.

An easier way might be to include this fix as a "ride along" in the first 67.0.x dot release.

[Tracking Requested - why for this release]:

Heads up to Relman that we might want to include this Fennec fix in a 67 Beta RC or 67.0.x dot release.

Comment 8

[Chris Peterson [:cpeterson]]

I just reproduced this bug and it's very bad! It breaks the whole "Make Firefox your default browser" feature if the user doesn't have a default browser set. We should really try to uplift this to 67.

Comment 9

[Andrei Teslovan [:ateslovan]]

Comment on attachment 9062206 [details]
Bug 1548000 - Default browser triggers "Default apps" screen; r?VladBaicu

Beta/Release Uplift Approval Request

• User impact if declined: If the user does not have a default browser set the experience of setting Fennec as your default browser becomes cumbersome.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Press hamburger icon and go to Settings.

2. Press "Make $Firefox your default browser"

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only removes a scenario where we were showing the "Choose with" dialog. Now, instead of this, we always redirect the user to the Android settings screen from where the user can pick the default browser.
• String changes made/needed:

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a43b68bbe67d
Default browser triggers "Default apps" screen; r=VladBaicu

Comment 11

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9062206 [details]
Bug 1548000 - Default browser triggers "Default apps" screen; r?VladBaicu

Uplift approved for the beta branch, thanks.

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a43b68bbe67d

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d6c5478f35e9

Comment 14

[Stefan Deiac]

Verified as fixed on Beta 67.0b17 using OnePlus 5T (Android 9) and Nexus 6P (Android 8.1.0).

Comment 15

[Stefan Deiac]

Also, verified as fixed on Nightly 68.0a1 (2019-05-05).