Closed Bug 1548329 Opened 5 years ago Closed 5 years ago

Load discovery stream feeds sequentially without blocking

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Flags:
Tracking Status
firefox68 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

Details

(Keywords: github-merged)

Possible perf gain.

Load feeds one at a time, and render what we can as the feeds are done.

If we go from the top to the bottom of the layout, and render until we hit something that's not ready, we can very likely render the above the fold caontent faster.

In my reference machine testing I saw improvements:

cached:
control:7.85/patch:6.61
no cached:
control:7.66/patch:7.3

To test, turn DS on and off, and watch it load.

If you watch it closely, you can see it loading from top to bottom as feeds are ready.

Assignee: nobody → sdowne
Type: defect → enhancement
Iteration: --- → 68.4 - Apr 29 - May 12
Priority: -- → P1
Blocks: 1534775
Blocks: 1549863

https://hg.mozilla.org/mozilla-central/rev/690025a0dcd5

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Regressions: 1550464
Regressions: 1550447

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190509214305) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the page is loaded from top to bottom as feeds are ready.

Status: RESOLVED → VERIFIED
status-firefox68: fixed → verified
Regressions: 1550053
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.