1548339 - Swizzle support in WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Dzmitry Malyshau [:kvark]]

glTextureStorage doesn't play well with BGRA8 textures on some platforms (MacOS and some Androids). We can work around it by having some of the textures swizzled by WebRender, at the cost of potentially breaking more batches.

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: WR swizzle configuration of texture units

allow the swizzle to be configurable with a texture binding

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kvark, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Dzmitry Malyshau [:kvark]]

No activity on the code side is expected - it's been in discussion.
We need to rework the code a bit to be less principled and catering to GL driver assumptions (accept BGRA inputs for RGBA internal format as a norm, but no windows/linux GL only)

Comment 5

[Dzmitry Malyshau [:kvark]]

Getting close to finishing this. One of the missing pieces is handling the blits correctly, in particular ones that are caused by tiled images.

Comment 6

[Dzmitry Malyshau [:kvark]]

Attachment: WR: Remove the color/alpha feature in cs_scale shader

this makes the shader simpler at no cost

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72904ab48c45
WR: Remove the color/alpha feature in cs_scale shader r=jrmuizel

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/72904ab48c45

Comment 9

[Dzmitry Malyshau [:kvark]]

Attachment: Fix WR saved alpha task sampling

looks like a typo that got unnoticed? I wonder how our alpha saved tasks work today :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4af33fd2da39
Fix WR saved alpha task sampling r=gw

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4af33fd2da39

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc58681d2407
WR swizzle configuration of texture units r=gw

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bc58681d2407