1548492 - Change remote canvas timeouts to check if other side is still open.

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P2)

Description

[Bob Owen (:bobowen)]

In bug 1464032 when waiting on semaphores for the other side to read or write, it uses a combination of long waits or an attempt to see if the other side is still reading.

This is to change that to a series of relatively short waits with checks to see if the related IPC channel is still open in between.

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1548492: Change remote canvas timeouts to check if other side is still open. r=jrmuizel!

This also fixes the CanvasParent destruction on channel close and error,
which was broken due to IPDL changes between rebases.

Comment 2

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/#/jobs?repo=try&duplicate_jobs=visible&selectedJob=255022538&revision=08ff233b9260539ba415742331e99ab7fda16afd

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/205bb2a0bc45
Change remote canvas timeouts to check if other side is still open. r=jrmuizel

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/205bb2a0bc45

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for uplift to Beta for Fx69 or can it ride to release with Fx70?

Comment 7

[Bob Owen (:bobowen)]

Remote 2D canvas is disabled at the moment.