1548673 - Rename a few macro and variables about intrinsic inline-size

Status: RESOLVED FIXED

(Core :: Layout, task, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Bug 1490611 added some FIXME to rename NS_INTRINSIC_WIDTH_UNKNOWN and nsBlockFrame::{mMinWidth, mPrefWidth}.

I'll post patches to rename them later.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1548673 Part 1 - Rename NS_INTRINSIC_WIDTH_UNKNOWN to NS_INTRINSIC_ISIZE_UNKNOWN. r?jfkthame

This patch is generated by running the following script under layout/,
and then manually delete the FIXME comment in LayoutConstants.h

#!/bin/bash
function rename() {
find .
-type f
! -path "./obj*"
! -path "./.git"
! -path "./.hg"
( -name ".cpp" -or
-name ".h" )
-exec sed -i -e "s/$1/$2/g" "{}" ;
}
rename NS_INTRINSIC_WIDTH_UNKNOWN NS_INTRINSIC_ISIZE_UNKNOWN

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1548673 Part 2 - Rename nsBlockFrame's mMinWidth to mCachedMinISize. r?jfkthame

Instead of renaming it to mMinISize, I choose mCachedMinISize because
both grid and flex container frames use mCachedMinISize for similar
purpose.

Depends on D29746

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1548673 Part 3 - Rename nsBlockFrame's mPrefWidth to mCachedPrefISize. r?jfkthame

Like Part 2, I choose mCachedPrefISize because grid and flex container
are using it.

Depends on D29747

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1548673 Part 4 - Fix the display macro usage in nsFileControlFrame::GetPrefISize(). r?jfkthame

Depends on D29748

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3ddb4c1ce28
Part 1 - Rename NS_INTRINSIC_WIDTH_UNKNOWN to NS_INTRINSIC_ISIZE_UNKNOWN. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/2a7dcc0cc43d
Part 2 - Rename nsBlockFrame's mMinWidth to mCachedMinISize. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/5ad9fb7a2713
Part 3 - Rename nsBlockFrame's mPrefWidth to mCachedPrefISize. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/00441f7cdd1c
Part 4 - Fix the display macro usage in nsFileControlFrame::GetPrefISize(). r=jfkthame

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a3ddb4c1ce28
https://hg.mozilla.org/mozilla-central/rev/2a7dcc0cc43d
https://hg.mozilla.org/mozilla-central/rev/5ad9fb7a2713
https://hg.mozilla.org/mozilla-central/rev/00441f7cdd1c