1548933 - Preview should ignore the search results

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Jason Laster [:jlast]]

Search results breakup the yellow highlight token.

STR

1. search for part of a token
2. pause
3. hover on the search result

Comment 1

[Jason Laster [:jlast]]

Attachment: search-preview.gif

Comment 2

[janelledement]

@jlast My first impulse is to deal with this problem at the moment addHighlight is called. This function adds the ‘preview-selection’ class to a target element which creates the yellow highlight. The preview object is available in props, one could check the target element's innerHTML against the preview.expression and see if there’s a complete match. If not, recursively compare the previous and next elements. If they’re innerHTML is found in the preview.expression, then add the highlight as well, and if not, stop searching. Would also have to make sure those extra elements had ‘preview-selection’ class removed as well when removeHighlight was called. What are your thoughts on this approach?

Comment 3

[Jason Laster [:jlast]]

Janel, sounds good.

Comment 4

[janelledement]

@jlast Ok, thanks. I'd like to claim this bug.

Comment 5

[janelledement]

Attachment: Bug 1548933 Preview should ignore search results. r=davidwalsh

This patch addresses bug 1548933. It adds the preview highlight to related tokens (if necessary) as well as the target token. This happens when one token is broken into pieces due to a search query that only covers part of the token.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dde6a8f2c41f
Preview should ignore search results. r=davidwalsh

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/dde6a8f2c41f