1549115 - Base telemetry events for HTML-based login manager

Status: RESOLVED FIXED

(Firefox :: about:logins, task, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

This bug tracks implementing recording of telemetry events for a few of the probes outlined in https://github.com/mozilla-lockbox/lockbox-addon/blob/master/src/background/telemetry.js

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549115 - Record telemetry events for about:logins page interactions. r?MattN

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

The patch in this bug should include tracking the 'copy' event as implemented in bug 1550093.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549115 - Only events dispatched from a shadow DOM target needs to have composed:true. r?_6a68

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549115 - Assign telemetry object names for copy-to-clipboard buttons. r?sfoster

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549115 - Add a test for telemetry events in about:logins. r?MattN

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Telemetry Data Review

Comment 7

[Chris H-C :chutten]

Comment on attachment 9070305 [details]
Telemetry Data Review

Preliminary note: 

To be clear, these collections do not contain the item GUID as mentioned in bug 1555821.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 74.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :jaws is responsible for renewing or removing the collection before it expires in Firefox 74.

---
Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fe74bee049e
Only events dispatched from a shadow DOM target needs to have composed:true. r=_6a68
https://hg.mozilla.org/integration/autoland/rev/72c14692f06c
Record telemetry events for about:logins page interactions. r=chutten,johannh,MattN,sfoster
https://hg.mozilla.org/integration/autoland/rev/7d2f103f518b
Assign telemetry object names for copy-to-clipboard buttons. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/978d0626cfe4
Add a test for telemetry events in about:logins. r=MattN

Comment 9

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-10%2Cm%28bc10%29&tochange=3b2489b9f469cc76a60ca025fb289cfadd7250cd&fromchange=e69430c126d73a919b73ed81002d690dea888358&group_state=expanded&selectedJob=250980482

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250980482&repo=autoland&lineNumber=2520

Backout link: https://hg.mozilla.org/integration/autoland/rev/574b69ad261ed4d1fa4d0bc96fc66b1969a39435

[task 2019-06-10T18:44:23.939Z] 18:44:23 INFO - TEST-START | browser/components/aboutlogins/tests/browser/browser_eventTelemetry.js
[task 2019-06-10T18:44:24.389Z] 18:44:24 INFO - GECKO(2497) | console.warn: LoginHelper: "Couldn't parse origin for" "about:logins" ({})
[task 2019-06-10T18:44:24.392Z] 18:44:24 INFO - GECKO(2497) | console.warn: LoginHelper: "Couldn't parse origin for" "about:logins" ({})
[task 2019-06-10T18:44:29.749Z] 18:44:29 INFO - TEST-INFO | started process screentopng
[task 2019-06-10T18:44:30.337Z] 18:44:30 INFO - TEST-INFO | screentopng: exit 0
[task 2019-06-10T18:44:30.338Z] 18:44:30 INFO - Buffered messages logged at 18:44:23
[task 2019-06-10T18:44:30.339Z] 18:44:30 INFO - Entering test bound setup
[task 2019-06-10T18:44:30.341Z] 18:44:30 INFO - Buffered messages logged at 18:44:24
[task 2019-06-10T18:44:30.343Z] 18:44:30 INFO - Leaving test bound setup
[task 2019-06-10T18:44:30.344Z] 18:44:30 INFO - Entering test bound test_telemetry_events
[task 2019-06-10T18:44:30.346Z] 18:44:30 INFO - Buffered messages finished
[task 2019-06-10T18:44:30.352Z] 18:44:30 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_eventTelemetry.js | Uncaught exception - waiting for telemetry event count of: 1 - timed out after 50 tries.
[task 2019-06-10T18:44:30.353Z] 18:44:30 INFO - Leaving test bound test_telemetry_events
[task 2019-06-10T18:44:30.354Z] 18:44:30 INFO - GECKO(2497) | MEMORY STAT | vsize 20974912MB | residentFast 982MB
[task 2019-06-10T18:44:30.355Z] 18:44:30 INFO - TEST-OK | browser/components/aboutlogins/tests/browser/browser_eventTelemetry.js | took 5999ms

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9023c24baae
Only events dispatched from a shadow DOM target needs to have composed:true. r=_6a68
https://hg.mozilla.org/integration/autoland/rev/4ea161f1dc1b
Record telemetry events for about:logins page interactions. r=chutten,johannh,MattN,sfoster
https://hg.mozilla.org/integration/autoland/rev/ff51c212dd01
Assign telemetry object names for copy-to-clipboard buttons. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/395ef2de31a9
Add a test for telemetry events in about:logins. r=MattN

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e1265c02345
Fix browser chrome failures on browser_parsable_script.js. r=jaws

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e9023c24baae
https://hg.mozilla.org/mozilla-central/rev/4ea161f1dc1b
https://hg.mozilla.org/mozilla-central/rev/ff51c212dd01
https://hg.mozilla.org/mozilla-central/rev/395ef2de31a9
https://hg.mozilla.org/mozilla-central/rev/7e1265c02345