1549288 - The about:newinstall header logo lacks contrast in dark mode

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Kestrel]

Attachment: Dark logo text against dark background

Comment 1

[Tim Nguyen :ntim]

At first, I was planning to add context-fill to the relevant images, but given how the images are currently made, this is slightly less trivial. Also, if this is the only place where context-fill is used for the branding, it will likely be forgotten next time the branding is changed.

This is why I'm tempted to think that removing the problematic part of the branding might be the better path here.

Dave, would it be ok to somehow do this ? Feel free to redirect to the right UX person :)

Comment 2

[Kestrel]

Attachment: Drop-shadow comparison

Some drop-shadow helps but the text still doesn't pop out like it should for such important branding.

Comment 3

[Verdi [:verdi] Best to slack me]

Ok looks like we need some SVGs with white text. I'll add them in a moment.

Comment 4

[Verdi [:verdi] Best to slack me]

Attachment: firefox-logo-horizontal-lockup-dark.svg

Comment 5

[Verdi [:verdi] Best to slack me]

Attachment: dev-logo-horizontal-lockup-dark.svg

Comment 6

[Verdi [:verdi] Best to slack me]

Attachment: nightly-logo-horizontal-lockup-dark.svg

Comment 7

[Verdi [:verdi] Best to slack me]

Attachment: nightly-unbranded-horizontal-lockup-dark.svg

Comment 8

[Tim Nguyen :ntim]

Attachment: Bug 1549288 - Clean up about:newinstall CSS and make it support dark mode. r=dao

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c6c0d39f1e9
Clean up about:newinstall CSS and make it support dark mode. r=dao

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6c6c0d39f1e9