1519547 - (dark-incontent-pages) [meta] Dark mode support for in-content pages

Status: NEW

(Firefox :: Theme, enhancement, P3)

Description

[Tim Nguyen :ntim]

Meta for making Firefox in-content pages dark. UX is generally positive with this idea given OSes today provide dark modes.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

We should add that to the release notes when ready!

Comment 3

[Martijn]

Which Firefox version is this targetted for?

While the release cycle (and issues getting fixed) for Firefox is arbitrarily slow, Dark Mode in other application keeps improving... Try not to lag behind please.

Comment 4

[Tim Nguyen :ntim]

If you're using Nightly, you can follow these instructions to enable dark mode support on about: pages :

• Enable the browser.in-content.dark-mode pref
• Enable your system's dark mode in case you haven't
• Restart your browser

If you see any visual bugs, please file them as a dependency for this bug :)

Comment 5

[Danny Colin [:sdk]]

Enable your system's dark mode in case you haven't

Would there be a way to active the dark mode in Firefox (via about:preferences or customizer) without having a system's dark mode?

Comment 6

[Tim Nguyen :ntim]

(In reply to Danny Colin [:sdk] from comment #5)

Enable your system's dark mode in case you haven't

Would there be a way to active the dark mode in Firefox (via about:preferences or customizer) without having a system's dark mode?

Bug 1529323

Comment 7

[Kestrel]

(In reply to Danny Colin [:sdk] from comment #5)

Would there be a way to active the dark mode in Firefox (via about:preferences or customizer) without having a system's dark mode?

ui.systemUsesDarkTheme = 1

Comment 10

[OmarRamiah]

And when I open any website (that is already in dark mode) while it's loading I get BIG FU**ING BLANK WHITE PAGE THAT ALMOST BLINDS ME until it loads the website !!!!!!

Not to mention the: settings, customize, add-ons page, about:config & everything else is still isn't dark, this is shameful.

Comment 11

[David Durst [:ddurst]]

Which Firefox version is this targetted for?

Can we get an answer on this, please?

Comment 12

[OmarRamiah]

When is this going to be fixed?? I'm almost getting blind in here !!

Comment 13

[Tim Nguyen :ntim]

(In reply to David Durst [:ddurst] from comment #11)

Which Firefox version is this targetted for?

Can we get an answer on this, please?

Whenever this is ready, I don't have time to work on it this month, but this just needs the most important issues to be fixed and a review to be done, so maybe this could ship in Firefox 70 ?

Comment 14

[paulflaherty5]

what version is this targeted to

Comment 15

[paulflaherty5]

could this issue be fixed in the next update

Comment 17

[OmarRamiah]

Could this be fixed ASAP before we get blind ?!?!?

Comment 18

[Luker]

(In reply to Tim Nguyen :ntim from comment #13)

(In reply to David Durst [:ddurst] from comment #11)

Which Firefox version is this targetted for?

Can we get an answer on this, please?

Whenever this is ready, I don't have time to work on it this month, but this just needs the most important issues to be fixed and a review to be done, so maybe this could ship in Firefox 70 ?

Is there any way to Change Firefox Theme Automatically After I change my windows theme to dark mode?

Comment 19

[OmarRamiah]

FINALLY !! It's all fixed in v70 !
Maybe I won't be switching to Edge anymore!
But now you need to add dark mode to your website... every inch of it..

Comment 20

[vagmer]

Didn't see view-source: page referenced here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1502552
https://bugzilla.mozilla.org/show_bug.cgi?id=1586529

Comment 21

[shalokshalom]

This!

I guess the XML view also belongs to this?

Since I got just shocked by a white flash, in the middle of the night by this:
https://kate-editor.org/syntax/data/syntax/fsharp.xml

Thanks :D

Comment 22

[Tim Nguyen :ntim]

(In reply to shalokshalom from comment #21)

This!

I guess the XML view also belongs to this?

Since I got just shocked by a white flash, in the middle of the night by this:
https://kate-editor.org/syntax/data/syntax/fsharp.xml

Thanks :D

Fixing view-source will mostly fix this as well (bug 1586529).

Comment 23

[Luker]

i use firefox linux version but dark mode is not complete like windows version and menu and settings are still white, i using 72.0.1 64 bit.

Comment 24

[jawadalkassim]

I'm Using Ubuntu 19.10 And Firefob 74.0.1 And Error Pages like "Hmm. We’re having trouble finding that site." still in White Background and Black Text, I've tried every thing nothing except ShadowFox Fixed The problem

Comment 25

[Tim Nguyen :ntim]

(In reply to jawadalkassim from comment #24)

I'm Using Ubuntu 19.10 And Firefob 74.0.1 And Error Pages like "Hmm. We’re having trouble finding that site." still in White Background and Black Text, I've tried every thing nothing except ShadowFox Fixed The problem

If you have privacy.resistFingerprinting enabled, you should disable it. Also, make sure you have a dark system theme enabled.

Comment 26

[grmat]

With a dark GTK theme most, but not all pages are now (FF 74.0.1) rendered dark.

Going through about:about, the following pages are shown in light themes:

about:checkerboard
about:debugging
about:home
about:webrtc
about:welcome
about:newtab (same as about:home)

Especially about:home is annoying because it's seen quite often.

about:credits: black text on dark background

Comment 27

[posilejte.spam]

Also depends on https://bugzilla.mozilla.org/show_bug.cgi?id=1702933

Comment 28

[Virsacer]

How can I disable this?

I have set Firefox to a dark theme, but that does not mean, that I want to see websites in their shi*** darkmode.

ui.systemUsesDarkTheme 0 and browser.in-content.dark-mode false seem to have no effect :/

At least some websites allow to turn it off, but they should not even get the info that I use a dark theme...

Comment 29

[Emilio Cobos Álvarez (:emilio)]

Wrong bug, see https://bugzilla.mozilla.org/show_bug.cgi?id=1529323. layout.css.prefers-color-scheme.content-override is what you want. 0 is dark, 1 light, 2 system, 3 browser. Extensions can also change this, see that bug.

Comment 30

[Virsacer]

Ah, this is great :)
Thank you!