Open Bug 1519547 (dark-incontent-pages) Opened 2 years ago Updated 2 months ago

[meta] Dark mode support for in-content pages

Categories

(Firefox :: Theme, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: ntim, Unassigned)

References

(Depends on 14 open bugs, Blocks 1 open bug)

Details

(Keywords: meta)

Meta for making Firefox in-content pages dark. UX is generally positive with this idea given OSes today provide dark modes.

Depends on: 1519548
See Also: → 1513529
Duplicate of this bug: 1520926

We should add that to the release notes when ready!

Depends on: 1408122
Depends on: 1529323
Depends on: 1523990
No longer depends on: 1523990
Depends on: 1539251
No longer depends on: 1539251
Depends on: 1544025, 1544026, 1544111
Summary: [meta] Make Firefox in-content pages match the dark theme → [meta] Ship dark mode support for in-content pages

If you're using Nightly, you can follow these instructions to enable dark mode support on about: pages :

  • Enable the browser.in-content.dark-mode pref
  • Enable your system's dark mode in case you haven't
  • Restart your browser

If you see any visual bugs, please file them as a dependency for this bug :)

Depends on: 1544114

Enable your system's dark mode in case you haven't

Would there be a way to active the dark mode in Firefox (via about:preferences or customizer) without having a system's dark mode?

Depends on: 1544225
Depends on: 1544226
Depends on: 1544227
Depends on: 1544228
Depends on: 1544239
Depends on: 1544241
No longer depends on: 1544228
Depends on: 1544510
Depends on: 1544887
Depends on: 1544904
Depends on: 1544909
Depends on: 1544998
Depends on: 1545016

(In reply to Danny Colin [:sdk] from comment #5)

Enable your system's dark mode in case you haven't

Would there be a way to active the dark mode in Firefox (via about:preferences or customizer) without having a system's dark mode?

Bug 1529323

Depends on: 1545029

(In reply to Danny Colin [:sdk] from comment #5)

Would there be a way to active the dark mode in Firefox (via about:preferences or customizer) without having a system's dark mode?

ui.systemUsesDarkTheme = 1

No longer depends on: 1544998
Depends on: 1545346
Depends on: 1545347
Depends on: 1545348
No longer depends on: 1545348
Depends on: 1544212
Depends on: 1545555
Depends on: 1545969
Depends on: 1546072
Depends on: 1546077
Depends on: 1545756, 1545757
Depends on: 1546150
No longer depends on: 1545756
Depends on: 1546155
Depends on: 1546042
Depends on: 1546540
Depends on: 1510567
Depends on: 1546582
Depends on: 1546583
Depends on: 1546585
Depends on: 1547558
Depends on: 1547937
Depends on: 1547941
Duplicate of this bug: 1546288
Depends on: 1549282
Depends on: 1549288
Depends on: 1549293
Depends on: 1549142
Duplicate of this bug: 1550988
Depends on: 1551165
Depends on: 1551202
Depends on: 1553385

Which Firefox version is this targetted for?

Can we get an answer on this, please?

Flags: needinfo?(ntim.bugs)
Blocks: 1555186
No longer blocks: 1555186
Depends on: 1555186
No longer depends on: 1555186
Depends on: 1555565
Depends on: 1519036

(In reply to David Durst [:ddurst] from comment #11)

Which Firefox version is this targetted for?

Can we get an answer on this, please?

Whenever this is ready, I don't have time to work on it this month, but this just needs the most important issues to be fixed and a review to be done, so maybe this could ship in Firefox 70 ?

Flags: needinfo?(ntim.bugs)
Depends on: 1551040
Duplicate of this bug: 1560850
Depends on: 1559302
Depends on: 1564614
Depends on: 1565051
Depends on: 1565081
Depends on: 1565085
Depends on: 1565086
Depends on: 1565089
Depends on: 1565090
Depends on: 1565092
No longer depends on: 1565092
Depends on: 1561955
Depends on: 1565254
Summary: [meta] Ship dark mode support for in-content pages → [meta] Dark mode support for in-content pages
Depends on: 1565896
Depends on: 1567938
See Also: → 1568364
See Also: 1568364
Depends on: 1575478
Depends on: 1584793
Depends on: 1588286
Blocks: 1588548
No longer blocks: 1588548

FINALLY !! It's all fixed in v70 !
Maybe I won't be switching to Edge anymore!
But now you need to add dark mode to your website... every inch of it..

Depends on: 1538522

This!

I guess the XML view also belongs to this?

Since I got just shocked by a white flash, in the middle of the night by this:
https://kate-editor.org/syntax/data/syntax/fsharp.xml

Thanks :D

Depends on: 1586529

(In reply to shalokshalom from comment #21)

This!

I guess the XML view also belongs to this?

Since I got just shocked by a white flash, in the middle of the night by this:
https://kate-editor.org/syntax/data/syntax/fsharp.xml

Thanks :D

Fixing view-source will mostly fix this as well (bug 1586529).

Depends on: 1603785
Depends on: 1606067
Depends on: 1608147
Depends on: 1608899
Depends on: 1609287

i use firefox linux version but dark mode is not complete like windows version and menu and settings are still white, i using 72.0.1 64 bit.

Depends on: 1610002
No longer depends on: 1610002
Depends on: 1610002

I'm Using Ubuntu 19.10 And Firefob 74.0.1 And Error Pages like "Hmm. We’re having trouble finding that site." still in White Background and Black Text, I've tried every thing nothing except ShadowFox Fixed The problem

(In reply to jawadalkassim from comment #24)

I'm Using Ubuntu 19.10 And Firefob 74.0.1 And Error Pages like "Hmm. We’re having trouble finding that site." still in White Background and Black Text, I've tried every thing nothing except ShadowFox Fixed The problem

If you have privacy.resistFingerprinting enabled, you should disable it. Also, make sure you have a dark system theme enabled.

With a dark GTK theme most, but not all pages are now (FF 74.0.1) rendered dark.

Going through about:about, the following pages are shown in light themes:

about:checkerboard
about:debugging
about:home
about:webrtc
about:welcome
about:newtab (same as about:home)

Especially about:home is annoying because it's seen quite often.

about:credits: black text on dark background

Blocks: dark-mode
Depends on: 1640913
Depends on: 1643245
Depends on: 1630327
Priority: -- → P3
Depends on: 1681674
Depends on: 1687183
Depends on: 1692301
Depends on: 1693663
Depends on: 1594920
You need to log in before you can comment on or make changes to this bug.