1549607 - Converge site Settings "search website" and site Exceptions "add / block website"

Status: NEW

(Firefox :: Settings UI, enhancement)

Description

[Dale Harvey (:daleharvey)]

Go to about:prefences -> privacy and security

In "Location" -> Settings a panel pops up that has a Search Website field but in
"Block pop-up windows" -> Exceptions a similiar panel pops up that has the ability to create a new Add or Block permission from a given url

It isnt consistent that the behaviour is different, and both functions are useful so I think we could add the ability to filter + create new permissions to both sections, making them more consistent and more functional.

Comment 1

[:Gijs (out for now; he/him)]

This is going to need UX work and I don't know who's working on this type of stuff at the moment. Just having 2 text fields underneath each other is going to be very confusing. Johann, do you know if this fits into any ongoing work in this space?

Comment 2

[Dale Harvey (:daleharvey)]

This was brought up as part of the work I was doing on https://bugzilla.mozilla.org/show_bug.cgi?id=1543812, Eric Pang was doing some of the UX here so can hopefully take a look

Comment 3

[Dale Harvey (:daleharvey)]

Sorry my browser keeps turning everything into defect

Comment 4

[Johann Hofmann [:johannh]]

Yeah we discussed this on Slack and I was asking whether the block-autoplay team wanted to take a stab at coming up with a pattern to use for all exception/permission dialogs (since they were running into this issue). I don't see anyone else ever prioritizing it...

Comment 5

[Gabi Cheta [:Gabi] Desktop QA]

Any updates on this enhancement?

Comment 7

[:Gijs (out for now; he/him)]

(In reply to Johann Hofmann [:johannh] from comment #4)

Yeah we discussed this on Slack and I was asking whether the block-autoplay team wanted to take a stab at coming up with a pattern to use for all exception/permission dialogs (since they were running into this issue). I don't see anyone else ever prioritizing it...

Do we just need a design first? We've got 2 generic dialogs, and it'd be pretty easy (I hope?) to switch various permissions over to it, if we can make a decision about which needs. Looks like atm:

Version A (permissions.xul):
Tracking protection exceptions
Cookie exceptions
Popup blocking exceptions
Password save prompt exceptions (where we don't prompt to save passwords)
Add-on install warning exceptions

Version B (sitePermissions.xul):
Geolocation, Camera, Microphone, Notification, Media autoplay permissions

Comment 8

[Dale Harvey (:daleharvey)]

Sorry havent had time to pick this up

I think there is a small amount of UX needed here, permissions.xul has a search icon with a "Search for a website" placeholder which helps inform the user that they can search, we at least want to change the placeholder to make it clear (when applicable) that they can also add new permissions, or use some type of indication that it isnt only for searching.