Closed Bug 1549810 Opened 7 months ago Closed 6 months ago

Filter logins based on page query parameter

Categories

(Firefox :: about:logins, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
firefox68 --- wontfix
firefox69 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

()

Details

(Whiteboard: [passwords:management] [skyline] )

Attachments

(4 files)

Assignee: nobody → jaws
Status: NEW → ASSIGNED

The search field can be populated through a URL query parameter when the page is opened via context menu "View Saved Logins" or autocomplete's "View Saved Logins".

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5b8f8b18666
Tests for filtering logins based on page query parameter. r=MattN
https://hg.mozilla.org/integration/autoland/rev/3034b68282fa
Initialize the value of the filter to the query parameter when set. r=MattN
https://hg.mozilla.org/integration/autoland/rev/807c329de7ea
Use the search filter when updating the login list. r=MattN
https://hg.mozilla.org/integration/autoland/rev/46fc2a3d94d1
Move all login-list-item interactions to render() so the filter will always be applied consistently. r=MattN

Can you provide some details on how this implementation should be verified correctly? Thanks.

Flags: needinfo?(jaws)

To test this bug, go to about:config and set signon.management.page.enabled=true and also set signon.management.overrideURI=about:logins

Then go to bugzilla.mozilla.org and attempt to log in
Click in the username field and a drop-down should appear to Browse for logins
Click on the button and about:logins should open with the search filter showing bugzilla.mozilla.org

Flags: needinfo?(jaws)

I don't think I could validate it in Windows 10 and Nightly v69.0a1 (2019-06-12).
My steps:

  1. Opened browser with a newly created profile.
  2. Go to about:config and
  • set:
    signon.management.page.enabled=true
  • create:
    signon.management.overrideURI=about:logins
  1. Go to bugzilla.mozilla.org

  2. Click "Log In"
    -> Login form appears as a drop-down.

  3. Click inside the "email" field.
    -> Nothing happens <-

  4. Log in and save a set of credentials

  5. Log out

  6. Click "Log In"
    -> Login form appears as a drop-down and the Password Manager drops down under the "Email field"
    -> "about:logins" did not open with search filter showing bugzilla.mozilla.org <-

  7. Click on the "View Saved Logins" button from the Password Manager drop-down.
    -> about:logins page is now displayed as Firefox Lockwise, but a filter showing bugzilla.mozilla.org is still not displayed.

Am I verifying correctly? Thanks.

Flags: needinfo?(jaws)

Sorry, I gave you a wrong instruction in comment 9. You will need to set signon.management.overrideURI=about:logins?filter=%DOMAIN%

The "?filter=%DOMAIN%" part at the end is required. Otherwise your steps sound correct.

Flags: needinfo?(jaws) → needinfo?(daniel.bodea)

With the newly given instructions, I have retaken the steps in comment 10. The difference is that when the user clicks on the "View Saved Logins" from the Password Manager drop-down (step 9), the about:logins page is displayed as Firefox Lockwise and a search is initiated for "bugzilla.mozilla.org".
The page's link address is "about:logins?filter=bugzilla.mozilla.org"

Does this behavior validate the intended implementation?

Behavior verified in Nightly v69.0a1 (2019-06-18). Thanks.

Flags: needinfo?(daniel.bodea) → needinfo?(jaws)

Yes, that validates the intended implementation.

Flags: needinfo?(jaws)

Based on the above, I will mark this bug as verified in Nightly v69.0a1 (2019-06-18). Thanks.

Status: RESOLVED → VERIFIED
Whiteboard: [passwords:management] [skyline]
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla69 → Firefox 69
You need to log in before you can comment on or make changes to this bug.