1549814 - Can open a blank LoginItem in Edit mode

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P3)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

This will allow for creation of logins. Logins should have an empty string for the formSubmitURL which will create them as "wildcard" logins not tied to a specific formSubmitURL.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549814 - Update common.inc.css to style password inputs similar to text inputs. r?MattN

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549814 - Update the login-list count on login additions and removals. r?MattN

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549814 - Include a title with the login object that removes http(s) or www prefix. r?MattN

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549814 - LoginHelper.searchLoginsWithObject always returns an array so no need to check for a falsy return value. r?MattN

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549814 - Add 'New Login' button to create new saved logins. r?MattN

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549814 - Add automated tests for creating a login. r?MattN

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3c8b0e8a870
Update common.inc.css to style password inputs similar to text inputs. r=MattN
https://hg.mozilla.org/integration/autoland/rev/dacfa366cb7e
Update the login-list count on login additions and removals. r=MattN
https://hg.mozilla.org/integration/autoland/rev/6c90643f1024
Include a title with the login object that removes http(s) or www prefix. r=MattN
https://hg.mozilla.org/integration/autoland/rev/78c10f828b20
LoginHelper.searchLoginsWithObject always returns an array so no need to check for a falsy return value. r=MattN
https://hg.mozilla.org/integration/autoland/rev/59f879c15252
Add 'New Login' button to create new saved logins. r=MattN,Pike
https://hg.mozilla.org/integration/autoland/rev/9fb6895ef8fd
Add automated tests for creating a login. r=MattN

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b3c8b0e8a870
https://hg.mozilla.org/mozilla-central/rev/dacfa366cb7e
https://hg.mozilla.org/mozilla-central/rev/6c90643f1024
https://hg.mozilla.org/mozilla-central/rev/78c10f828b20
https://hg.mozilla.org/mozilla-central/rev/59f879c15252
https://hg.mozilla.org/mozilla-central/rev/9fb6895ef8fd

Comment 10

[Timea Cernea [:tbabos][inactive]]

Verified - fixed on latest Nightly 69.0a1 (2019-05-23) (64-bit) on Windows 10 x64, Mac OS 10.13 and Ubuntu 18.04.

• New Login button is available and allows the user to create new logins
• Entry count is updated after adding or removing newly created logins
• Password styling is applied correctly for new logins
• The https:// or www prefixes are correctly removed from the new entry title

However, adding a new login via the button - after we already added one using the same method - will pre-fill the Website Adress with the address from the previous entry.

Jared, should I submit a bug for this or it is known/expected?

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Timea Babos [on PTO until 19th Aug - ni? Brindusa Tot] from comment #10)

However, adding a new login via the button - after we already added one using the same method - will pre-fill the Website Adress with the address from the previous entry.

Jared, should I submit a bug for this or it is known/expected?

I can't reproduce this on latest mozilla-central builds. I think it has been since fixed. Please file a new bug if you are still able to reproduce this.