1553373 - xul:textbox type=password show multiple borders

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

xul:textbox[type=password] is implemented via an inner html:input[type=password]. The changes in bug 1549814 are causing a double border to appear on html:input[type=password] when the input is focused.

This is visible in the Set Master Password dialog in about:preferences.

We could change the CSS to not apply these styles to xul:textbox that have a type attribute specified.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1553373 - Don't apply special styling to xul:textbox[type=password] since its descendant html:input[type=password] will get appropriate styling. r?dao

Comment 2

[Dão Gottwald [:dao]]

(In reply to (Limited availability 5/20-5/24) Jared Wein [:jaws] (please needinfo? me) from comment #0)

xul:textbox[type=password]

Do we need to keep supporting this at all?

This is visible in the Set Master Password dialog in about:preferences.

Could this use <input type="password">?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Dão Gottwald [::dao] from comment #2)

(In reply to (Limited availability 5/20-5/24) Jared Wein [:jaws] (please needinfo? me) from comment #0)

xul:textbox[type=password]

Do we need to keep supporting this at all?

This is visible in the Set Master Password dialog in about:preferences.

Could this use <input type="password">?

Yeah, that would be simpler and in the right direction.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1553373 - Change to use html:input type=password instead of xul:textbox type=password in Master Password dialogs since they use common styling which defines proper styling for html:input[type=password] now. r?dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6cb5057e282
Change to use html:input type=password instead of xul:textbox type=password in Master Password dialogs since they use common styling which defines proper styling for html:input[type=password] now. r=dao

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f6cb5057e282

Comment 7

[Rares Doghi, Desktop QA]

Hi, I managed to reproduce this issue in an older version of Nightly 69.0a1 (2019-05-22) but it no longer occurs in Nightly 69.0a1 (2019-05-29).
This issue was tested on All operating systems.