1549847 - NSS's SQLite compilation warnings make the build fail on iOS

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Edouard Oger [:eoger]]

ninja: Entering directory `/Users/eoger/bobo/nss-3.43/nss/out/Release-iphoneos/'
[309/779] CC obj/lib/sqlite/sqlite.sqlite3.o
FAILED: obj/lib/sqlite/sqlite.sqlite3.o
cc -MMD -MF obj/lib/sqlite/sqlite.sqlite3.o.d -DSQLITE_THREADSAFE=1 -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_USE_64 -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DHAVE_BSD_FLOCK -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DDARWIN -DNSS_DISABLE_DBM -DNSS_DISABLE_LIBPKIX -DNDEBUG -I/Users/eoger/bobo/nss-3.43/nspr_dist/dist/include/nspr -I/Users/eoger/bobo/nss-3.43/nss_dist/private/nss -I/Users/eoger/bobo/nss-3.43/nss_dist/nss -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.2.sdk -fasm-blocks -mpascal-strings -O2 -gdwarf-2 -miphoneos-version-min=11.0 -arch arm64 -fPIC -fno-common -pipe -Werror -Wall -Wno-array-bounds -Wno-unevaluated-expression -Wno-parentheses-equality -Qunused-arguments -Wshadow  -c ../../lib/sqlite/sqlite3.c -o obj/lib/sqlite/sqlite.sqlite3.o
../../lib/sqlite/sqlite3.c:18400:17: error: 'OSAtomicCompareAndSwapPtrBarrier' is deprecated: first deprecated in iOS 10.0 - Use atomic_compare_exchange_strong() from <stdatomic.h> instead [-Werror,-Wdeprecated-declarations]
      success = OSAtomicCompareAndSwapPtrBarrier(NULL, newzone,
                ^
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.2.sdk/usr/include/libkern/OSAtomicDeprecated.h:547:6: note: 'OSAtomicCompareAndSwapPtrBarrier' has been explicitly marked deprecated here
bool    OSAtomicCompareAndSwapPtrBarrier( void *__oldValue, void *__newValue, void * volatile *__theValue );
        ^
../../lib/sqlite/sqlite3.c:26960:6: error: "gethostuuid() is disabled." [-Werror,-W#warnings]
#    warning "gethostuuid() is disabled."
     ^
2 errors generated.
[322/779] CC obj/lib/ssl/ssl.ssl3con.o
ninja: build stopped: subcommand failed.

Patch incoming.

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1549847 - Do not treat warnings as errors on iOS.

Comment 2

[J.C. Jones [:jcj] (he/him)]

https://hg.mozilla.org/projects/nss/rev/c4df81ef077968c622da6fac2de0a3489cae73ea

Comment 3

[Martin Thomson [:mt:]]

We should open a bug to fix these. Warnings don't exist for no reason. And we could probably use an update.

If comment 0 shows the only error, maybe updating sqlite would have worked out better.

Comment 4

[Edouard Oger [:eoger]]

This was regressed by bug 1550636.

FAILED: obj/lib/sqlite/sqlite.sqlite3.o 
cc -MMD -MF obj/lib/sqlite/sqlite.sqlite3.o.d -DHMAC_Update=NSS_HMAC_Update -DHMAC_Init=NSS_HMAC_Init -DMD5_Update=NSS_MD5_Update -DSHA1_Update=NSS_SHA1_Update -DSHA256_Update=NSS_SHA256_Update -DSHA224_Update=NSS_SHA224_Update -DSHA512_Update=NSS_SHA512_Update -DSHA384_Update=NSS_SHA384_Update -DSEED_set_key=NSS_SEED_set_key -DSEED_encrypt=NSS_SEED_encrypt -DSEED_decrypt=NSS_SEED_decrypt -DSEED_ecb_encrypt=NSS_SEED_ecb_encrypt -DSEED_cbc_encrypt=NSS_SEED_cbc_encrypt -DSQLITE_THREADSAFE=1 -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X64 -DNSS_USE_64 -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DHAVE_BSD_FLOCK -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DDARWIN -DNSS_DISABLE_DBM -DNSS_DISABLE_LIBPKIX -DNDEBUG -I/var/folders/1b/gl7yt7ds26vcyr1pkgld6l040000gn/T/tmp.PQ2yQU7C/dist/include/nspr -I/var/folders/1b/gl7yt7ds26vcyr1pkgld6l040000gn/T/tmp.L6qCMXRn/private/nss -I/var/folders/1b/gl7yt7ds26vcyr1pkgld6l040000gn/T/tmp.L6qCMXRn/public/nss -isysroot /Applications/Xcode-10.2.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.2.sdk -fasm-blocks -mpascal-strings -O2 -gdwarf-2 -mios-simulator-version-min=11.0 -arch x86_64 -fPIC -fno-common -pipe -Werror -Wall -Wno-array-bounds -Wno-unevaluated-expression -Wno-parentheses-equality -Qunused-arguments -Wshadow  -c ../../lib/sqlite/sqlite3.c -o obj/lib/sqlite/sqlite.sqlite3.o
../../lib/sqlite/sqlite3.c:32490:6: error: "gethostuuid() is disabled." [-Werror,-W#warnings]
#    warning "gethostuuid() is disabled."
     ^
1 error generated.

Comment 5

[Martin Thomson [:mt:]]

Yes, let's just see if we can disable warnings entirely for sqlite.

Comment 6

[Edouard Oger [:eoger]]

Attachment: Bug 1549847 - Ignore sqlite compilation warnings.

Comment 7

[J.C. Jones [:jcj] (he/him)]

https://hg.mozilla.org/projects/nss/rev/7f146eb7adacabb83dc7f77083776b28956c5528

Comment 8

[J.C. Jones [:jcj] (he/him)]

Really it was fixed in 3.44. Let's not add this to the 3.46 relnotes.