1549915 - Youtube AV1 video glitch(block noise)

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Alice0775 White]

Attachment: screenshot bad .vs. good

[Tracking Requested - why for this release]: Youtube video is important. Firefox 68 should not release until fix this.

Reproducible: always

Steps to Reproduce:

1. Open https://youtu.be/NL2jL_ZMuqU?t=79

Actual Results:
Block noise appears

Expected Results:
no such glitch

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=98adabf295d0bdd1d48cf715fb8ac8ea4ead8766&tochange=8ce9905a2eec887a9b4ed63798961cef1fa3fded

Regressed by: Bug 1540830

Comment 1

[Alice0775 White]

Alex Chronopoulos [:achronop],
Your patch seems to cause the glitch. Can you please look into this?

Comment 2

[Alice0775 White]

Attachment: Status for nerds

Comment 3

[Alice0775 White]

Attachment: about:support

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

and if you can't reproduce it, go to https://www.youtube.com/testtube and enable "Always Prefer AV1" instead of default "Auto"

Comment 5

[Alex Chronopoulos [:achronop]]

Thanks for the detailed information. I can reproduce that in my win 10 machine latest Nightly. I will report it upstream.

Comment 6

[Alex Chronopoulos [:achronop]]

The following issue filed upstream: https://code.videolan.org/videolan/dav1d/issues/275

Comment 7

[Alex Chronopoulos [:achronop]]

It would be helpful to know if anyone with AVX2-capable CPU can reproduce this.

Comment 8

[Mayank Bansal]

(In reply to Alex Chronopoulos [:achronop] from comment #7)

It would be helpful to know if anyone with AVX2-capable CPU can reproduce
this.

I have a AVX2 enabled CPU (Broadwell-U). I enabled AV1, and confirmed the video was serving AV1 video by checking the stats-for-nerds.
I was not able to repro the glitch.
I assume that the glitch is the "blueish color" of background and hands in the video at 1:19-1:21 mark.

Comment 9

[Alex Chronopoulos [:achronop]]

Thank you very much for checking, that was very helpful. I have reported that upstream. The issue is fixed now.

Comment 10

[Alex Chronopoulos [:achronop]]

dav1d import: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a47a418c360dd1c6bb97cda46b4ebc0ab1a3c9b1

Comment 11

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1549915 - Import dav1d from upstream to a713643. r?TD-Linux

Comment 12

[Thomas Daede [:TD-Linux]]

I think 67 (beta) may have an old enough dav1d that this doesn't occur. Can someone on windows check?

Comment 13

[Alice0775 White]

(In reply to Thomas Daede [:TD-Linux] from comment #12)

I think 67 (beta) may have an old enough dav1d that this doesn't occur. Can
someone on windows check?

I cannot reproduce this problem on Firefox67.0b18 Windows10.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd4958dfdea0
Import dav1d from upstream to a713643. r=TD-Linux

Comment 15

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/dd4958dfdea0

Comment 16

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2019-05-07) on Windows 10 x64.
I retested everything using latest Nightly 69.0a1 and Firefox 68.0b12 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64 and the bug is not reproducing anymore.