1546070 - Crash in [@ dav1d_recon_b_inter_8bpc]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-e776f09b-4ff4-442b-8da9-3e39e0190420.

Top 10 frames of crashing thread:

0  @0x7f0f59bb0200 
1 libxul.so dav1d_recon_b_inter_8bpc media/libdav1d/8bd_recon_tmpl.c:1513
2 libxul.so decode_b third_party/dav1d/src/decode.c:748
3 libxul.so decode_sb third_party/dav1d/src/decode.c:2040
4 libxul.so decode_sb third_party/dav1d/src/decode.c:2088
5 libxul.so decode_sb third_party/dav1d/src/decode.c:2081
6 libxul.so dav1d_decode_tile_sbrow third_party/dav1d/src/decode.c:2447
7 libxul.so dav1d_tile_task third_party/dav1d/src/thread_task.c:92
8 libpthread-2.29.so libpthread-2.29.so@0x85a1 
9 libc-2.29.so libc-2.29.so@0xfb022 

There are 170 crashes (from 64 installations) in nightly 68 starting with buildid 20190420095532. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1540830.

[1] https://hg.mozilla.org/mozilla-central/rev?node=a5108ffbd311

Comment 1

[Alex Chronopoulos [:achronop]]

Reported upstream in https://code.videolan.org/videolan/dav1d/issues/272

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1546070 - Update dav1d from upstream to f8cac8c. r?TD-Linux

The imported version is just one commit over 0.2.2 and solves the crash for this bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abcd7426fb63
Update dav1d from upstream to f8cac8c. r=TD-Linux

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/abcd7426fb63

Comment 6

[Nils Ohlmeier [:drno]]

Comment on attachment 9059832 [details]
Bug 1546070 - Update dav1d from upstream to f8cac8c. r?TD-Linux

Beta/Release Uplift Approval Request

• User impact if declined: Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1540830#c12 for the details.
  Just requesting here as well to ensure they both get considered together.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1540830
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A very simple patch which has proven to address the problem in Nightly.
• String changes made/needed: N/A

Comment 7

[Pascal Chevrel:pascalc]

We currently don't have enough bake time in nightly to take this uplift in our last beta before RC but I am keeping the uplift request open as I think it could be a good ridealong for a 67 dot release if we do not detect any serious stability regression on Deved/beta 68 in the next 2 to 3 weeks.

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9059832 [details]
Bug 1546070 - Update dav1d from upstream to f8cac8c. r?TD-Linux

(In reply to Pascal Chevrel:pascalc from comment #7)

We currently don't have enough bake time in nightly to take this uplift in our last beta before RC but I am keeping the uplift request open as I think it could be a good ridealong for a 67 dot release if we do not detect any serious stability regression on Deved/beta 68 in the next 2 to 3 weeks.

This patch caused a Youtube regression in bug 1549915, I don't think it's a good candidate for uplifting in a dot release.