1549987 - QuickOpen scrolls jankily

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Jason Laster [:jlast]]

STR:

1. open the debugger
2. cmd+p to open quick open
3. press arrow key down continuously

Notice how the focus state tries to scroll to the middle. Compare with other editors like vs code, which keep focus state at the bottom...

Comment 1

[Jason Laster [:jlast]]

Attachment: QuickOpen - scrolling.gif

Comment 2

[David Walsh :davidwalsh]

Attachment: Bug 1549987 - Improve scrolling feel for quick open r=jlast

Removes the smoothscrolling for QuickOpen

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d527b0b37b4
Improve scrolling feel for quick open r=jlast

Comment 4

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 6d527b0b37b4 (Bug 1549987) for debugger failure CLOSED TREE

Failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-debugger-tests%2Cnode%28debugger%29&selectedJob=245594195
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245594195&repo=autoland&lineNumber=322

[task 2019-05-09T18:23:31.046Z]
[task 2019-05-09T18:23:31.046Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/SecondaryPanes/WhyPaused.js
[task 2019-05-09T18:23:31.046Z] 44:7 warning Do not use setState in componentDidUpdate react/no-did-update-set-state
[task 2019-05-09T18:23:31.046Z]
[task 2019-05-09T18:23:31.046Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/shared/Popover.js
[task 2019-05-09T18:23:31.046Z] 61:7 warning Do not use setState in componentDidMount react/no-did-mount-set-state
[task 2019-05-09T18:23:31.046Z]
[task 2019-05-09T18:23:31.046Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/utils/result-list.js
[task 2019-05-09T18:23:31.046Z] 8:10 error 'transitionTimeout' is defined but never used no-unused-vars
[task 2019-05-09T18:23:31.046Z]
[task 2019-05-09T18:23:31.046Z] /builds/worker/checkouts/gecko/devtools/client/debugger/src/utils/sources-tree/tests/addToTree.spec.js
[task 2019-05-09T18:23:31.046Z] 297:5 warning Disabled test jest/no-disabled-tests
[task 2019-05-09T18:23:31.046Z]
[task 2019-05-09T18:23:31.046Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/component/basic.js
[task 2019-05-09T18:23:31.046Z] 346:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-09T18:23:31.046Z] 376:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-09T18:23:31.046Z]
[task 2019-05-09T18:23:31.046Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/component/expand.js
[task 2019-05-09T18:23:31.046Z] 188:3 warning Disabled test jest/no-disabled-tests
[task 2019-05-09T18:23:31.046Z]
[task 2019-05-09T18:23:31.046Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/component/release-actors.js
[task 2019-05-09T18:23:31.046Z] 75:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-09T18:23:31.046Z]
[task 2019-05-09T18:23:31.046Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/utils/make-numerical-buckets.js
[task 2019-05-09T18:23:31.046Z] 31:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-09T18:23:31.046Z] 49:3 warning Skipped test jest/no-disabled-tests
[task 2019-05-09T18:23:31.047Z]
[task 2019-05-09T18:23:31.047Z] /builds/worker/checkouts/gecko/devtools/client/debugger/packages/devtools-reps/src/reps/tests/grip.js
[task 2019-05-09T18:23:31.047Z] 599:1 warning Skipped test suite jest/no-disabled-tests
[task 2019-05-09T18:23:31.047Z]
[task 2019-05-09T18:23:31.047Z] ✖ 13 problems (1 error, 12 warnings)
[task 2019-05-09T18:23:31.047Z]
[task 2019-05-09T18:23:31.047Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2019-05-09T18:23:31.047Z]
[task 2019-05-09T18:23:31.047Z] TEST-UNEXPECTED-FAIL | error 'transitionTimeout' is defined but never used no-unused-vars
[task 2019-05-09T18:23:31.047Z] TEST START | Jest
[task 2019-05-09T18:26:40.056Z] PASS devtools-reps test packages/devtools-reps/src/reps/tests/grip-array.js
[task 2019-05-09T18:26:40.056Z] PASS devtools-components test packages/devtools-components/src/tests/tree.js
[task 2019-05-09T18:26:40.056Z] PASS devtools-reps test packages/devtools-reps/src/reps/tests/grip.js
[task 2019-05-09T18:26:40.056Z] PASS test src/utils/resource/tests/query.spec.js (13.304s)
[task 2019-05-09T18:26:40.056Z] PASS devtools-reps test packages/devtools-reps/src/reps/tests/string-with-url.js
[task 2019-05-09T18:26:40.056Z] ● Console
[task 2019-05-09T18:26:40.056Z]
[task 2019-05-09T18:26:40.056Z] console.error node_modules/fbjs/lib/warning.js:33
[task 2019-05-09T18:26:40.056Z] Warning: Each child in an array or iterator should have a unique "key" prop.
[task 2019-05-09T18:26:40.056Z]
[task 2019-05-09T18:26:40.056Z] Check the top-level render call using <span>. See https://fb.me/react-warning-keys for more information.
[task 2019-05-09T18:26:40.056Z] in span

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d82ae6b2d2d9
Backed out changeset 6d527b0b37b4 for debugger failure CLOSED TREE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b97aef38d556
Improve scrolling feel for quick open r=jlast

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b97aef38d556