Closed Bug 1550025 Opened 7 months ago Closed 7 months ago

quantumbar breaks "search bookmarks via address bar" behavior when bookmark suggest is turned off

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- verified
firefox69 --- verified

People

(Reporter: bzbarsky, Assigned: mak)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STEPS TO REPRODUCE:

  1. Use a build with "browser.urlbar.quantumbar" set to true (in my case a nightly starting 2019-05-03 on Linux).

  2. Open about:preferences, go to "Privacy & Security" section, and uncheck "Bookmarks" in the "Address Bar" ("When using the address bar, suggest") section.

  3. Create a bookmark with a tag named "test".

  4. Type "* test" in the URL bar.

EXPECTED RESULTS: The bookmark is suggested, in spite of the setting from step 2, since this is an explicit search on bookmarks.

ACTUAL RESULTS: The bookmark is not suggested.

ADDITIONAL INFORMATION: Toggling "browser.urlbar.quantumbar" to false restores the expected behavior.

On Mac, for some reason, this regressed way back in April before quantumbar was enabled; I am still trying to pin down that regression.

Regressed by: quantumbar-model

Ah, the Mac thing was to do with the testing setup and force-downgraded profiles: An April 11 build works with a current profile, but an April 12 build does not (!).

So all that's going on here is the quantumbar bit.

No longer regressed by: quantumbar-model
Points: --- → 3
Priority: -- → P2

Probably the filtering code in the providers manager is not overriding the bookmarks pref with the bookmarks restriction token. If nobody looks into this earlier, I may have a look tomorrow.

Assignee: nobody → mak77
Status: NEW → ASSIGNED
Iteration: --- → 68.4 - Apr 29 - May 12
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/763d3da98117
In Quantum Bar the restriction tokens should bypass the restriction prefs. r=adw
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: qe-verify+
QA Contact: aflorinescu

Reproduced the regression on 68.0a1 20190506130308, then verified it as fixed on:

             Ubuntu 16.04 && Windows 10 && Mac 10.14:
                                          beta            68.0b7 2019-06-03
                                          nightly        69.0a1 2019-06-06
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.