Closed Bug 1550087 Opened 7 months ago Closed 2 months ago

Link users to the login they are duplicating in the error message

Categories

(Firefox :: about:logins, enhancement, P3)

70 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- verified
firefox71 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline] [strings])

Attachments

(3 files)

When a user creates a login, we should check that the hostname, username, and password are not already present in the storage (with a wildcard formSubmitURL).

Flags: qe-verify+
Assignee: nobody → djustice
Whiteboard: [passwords:management] [skyline]
Assignee: djustice → nobody
Whiteboard: [passwords:management] [skyline] → [passwords:management] [skyline] [strings]
Depends on: 1550122
Summary: Prevent users from creating duplicate logins → Link users to the login they are duplicating in the error message

This can be implemented without adding new strings by just linking the current error message to the existing login.

Assignee: nobody → jaws
Status: NEW → ASSIGNED
Whiteboard: [passwords:management] [skyline] [strings] → [passwords:management] [skyline]
Whiteboard: [passwords:management] [skyline] → [passwords:management] [skyline] [strings]
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3082c1a8f7b
Set l10n-id statically on the dismiss-breach-alert button. r=MattN
https://hg.mozilla.org/integration/autoland/rev/ea553ba219cd
Alphabetize the event listeners and refactor to shorten the focus and render methods on LoginItem. r=MattN
https://hg.mozilla.org/integration/autoland/rev/d3e85469f539
Link users to the login they are duplicating in the error message. r=MattN,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

I have verified this issue on the latest Nightly (Build ID: 20191003214801) on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64.

  • The “Go to existing entry? “ link is displayed in the error message.
  • The existing login is focused after clicking on the “Got to existing entry” link and discard the changes.
  • The “Close this alert” tooltip is correctly displayed when hover the “x” button from Breached alert.

Leaving this to ride with 71 (because of the string change) after discussing with jaws

Now with fewer string changes!

And ok for jaws' batch uplift.

Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla71 → Firefox 71
Version: Trunk → 70 Branch

I have verified this issue on the Firefox Beta 70.0b13 (Build ID: 20191007220302) on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64.

  • The error message is hyperlinked.
  • The existing login is focused after clicking on the error message link and discard the changes.
  • The “Close this alert” tooltip is correctly displayed when hover the “x” button from Breached alert.
You need to log in before you can comment on or make changes to this bug.