1550087 - Link users to the login they are duplicating in the error message

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

When a user creates a login, we should check that the hostname, username, and password are not already present in the storage (with a wildcard formSubmitURL).

Comment 1

[Dave Justice]

Seems like we should only check against username and hostname. we wouldn't want duplicates of the same usernames on the same hostnames with different passwords.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This can be implemented without adding new strings by just linking the current error message to the existing login.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1550087 - Set l10n-id statically on the dismiss-breach-alert button. r?MattN

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1550087 - Alphabetize the event listeners and refactor to shorten the focus and render methods on LoginItem. r?MattN

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1550087 - Link users to the login they are duplicating in the error message. r?MattN

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3082c1a8f7b
Set l10n-id statically on the dismiss-breach-alert button. r=MattN
https://hg.mozilla.org/integration/autoland/rev/ea553ba219cd
Alphabetize the event listeners and refactor to shorten the focus and render methods on LoginItem. r=MattN
https://hg.mozilla.org/integration/autoland/rev/d3e85469f539
Link users to the login they are duplicating in the error message. r=MattN,fluent-reviewers,flod

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c3082c1a8f7b
https://hg.mozilla.org/mozilla-central/rev/ea553ba219cd
https://hg.mozilla.org/mozilla-central/rev/d3e85469f539

Comment 8

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly (Build ID: 20191003214801) on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64.

• The “Go to existing entry? “ link is displayed in the error message.
• The existing login is focused after clicking on the “Got to existing entry” link and discard the changes.
• The “Close this alert” tooltip is correctly displayed when hover the “x” button from Breached alert.

Comment 9

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Leaving this to ride with 71 (because of the string change) after discussing with jaws

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/6b5edb8a4014
https://hg.mozilla.org/releases/mozilla-beta/rev/e958a5a1cd5d
https://hg.mozilla.org/releases/mozilla-beta/rev/2ac46acbd868

Comment 11

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Now with fewer string changes!

Comment 12

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

And ok for jaws' batch uplift.

Comment 13

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the Firefox Beta 70.0b13 (Build ID: 20191007220302) on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64.

• The error message is hyperlinked.
• The existing login is focused after clicking on the error message link and discard the changes.
• The “Close this alert” tooltip is correctly displayed when hover the “x” button from Breached alert.