1586200 - The website address link is no longer opened if it's clicked

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: link is not opened on click.gif

[Affected Versions]:

• Nightly 71.0a1

[Affected Platforms]

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have at least one saved logins.

[Steps to reproduce]:

1. Open the latest Nightly browser and navigate to "about:logins" page.
2. Select any of the saved logins.
3. Right click on the website address link.
4. Observe the behavior.

[Expected results]:

• The website is opened in a new tab.

[Actual results]:

• Nothing happens.

[Regression]:

• The issue is not reproducible with older Nightly 71.0a1 (2019-09-03) build. Considering this, using mozregression tool I have found a pushlog which contains the issue that broke this in the latest Nightly build. Here are the results:
• Pushlog: https://tinyurl.com/y39ej5a9
• Last good revision: ff09f16f5b3d5310a96675f53671b622a5aa1e5e
• First bad revision: faaf976800c27b0f423a69deb5fd6a6dd557de98

This pushlog contains multiple patches and we are not sure which one introduced this behavior.
@Jared can you please take a look?

[Notes]:

• The issue is not reproducible if you are using the middle click. The website is correctly opened in a new tab if you are using the middle click.
• Attached a screen recording with the issue.

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

It seems that the website address link is correctly opened if "Website address" label is clicked.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1586200 - Use target instead of originalTarget since originalTarget is restricted if native anonymous content was clicked. r?sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d58b1cdf387
Use target instead of originalTarget since originalTarget is restricted if native anonymous content was clicked. r=MattN

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9d58b1cdf387

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 ( Build ID: 20191008093420) on Windows 10 x64, MacOS 10.14 and Ubuntu 16.04 x64.

• The website is opened in a new tab after clicking on the website address link.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift to beta? Thanks!

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9099240 [details]
Bug 1586200 - Use target instead of originalTarget since originalTarget is restricted if native anonymous content was clicked. r?sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Clicking on the website link doesn't do anything even though it looks like a link
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Covered by automated tests and has been verified by QA. Only affects about:logins and the patch is very minimal.
• String changes made/needed: none

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9099240 [details]
Bug 1586200 - Use target instead of originalTarget since originalTarget is restricted if native anonymous content was clicked. r?sfoster

Fix for a link for Skyline feature, let's uplift for beta 14.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This needs a new patch for beta.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

I am sorry, comment #0 is correct in that Firefox 70 is unaffected. This bug was regressed by bug 1550087 which had an alternate patch uplifted to beta. This alternate beta patch did not introduce the regression on beta.