1550100 - Slight shuffling of content as snippets load in DS

Status: NEW

(Firefox :: New Tab Page, defect, P2)

Description

[Scott [:thecount] Downe]

When the page is loading, snippets could load later, which would cause loaded content below it, like stories and topsites, to shift down a bit.

Comment 1

[Punam Dahiya [:pdahiya]]

Hi Scott,
Is this specific to snippet loading on top, will help if you can add some more steps to help replicate this issue. Thanks

Comment 2

[Scott [:thecount] Downe]

It's not happening right now, because a snippet isn't being shown, not sure why, I dunno how to enable it atm. We should figure out how to enable some sort of dev snippet to test reliably.

But basically the rest of the content "topsites, stories, anything else in the layout" can load before or after the snippet loads.

The snippet now loads at the top of the layout, but below search. This causes content to shuffle down if the layout finishes before the snippet loads.

Comment 3

[Ed Lee :Mardak]

Maybe we could know that we will render the below-search-snippet sooner to reserve space to avoid shifting the page? I guess the snippets asrouter code runs slightly later currently

Comment 4

[Punam Dahiya [:pdahiya]]

NI Tawanda to help clarify if simple_below_search_snippet is going away from new tab in near future. Syncing up with Kate hinted that snippet below search was planned to be short term.

This will help to decide if its worth doing refactoring to make SNIPPETS_REQUEST sooner to find out if we need to reserve space. This refactoring is not trivial and possible to have some increase in above the fold performance numbers as we will be moving request to find snippets to load earlier on opening new tab.

Comment 5

[Tawanda Kanhema]

Punan, my understanding is that we will have the snippet through the end of the year at least so it's probably a good idea to continue support.

Comment 6

[Punam Dahiya [:pdahiya]]

Options are:

1. We can either always show a snippet for some layout
2. or we take slight regression in performance in order to wait for snippet.

Comment 7

[Scott [:thecount] Downe]

Snippet loaded would be considered blocker for performance final paint anyway.

Comment 8

[Ed Lee :Mardak]

In the common case for most users and for most tabs, I don't think there would be the special below-search snippet shown, so it doesn't seem to make sense to optimize for it nor include it as part of performance measurements.

Comment 9

[Jessilyn Davis]

Pending test results, will make this P1 when we know the plan for under the search bar snippet.